From 7e574d997e01a5cd2529648cf96648534be98b15 Mon Sep 17 00:00:00 2001 From: Tommy Nguyen <4123478+tido64@users.noreply.github.com> Date: Wed, 7 May 2025 14:02:58 +0200 Subject: [PATCH] ci(macos): re-enable smoke test Also removed the x86 build step that hasn't built for x86 ever since we moved to ARM64 runners. --- .github/workflows/build.yml | 21 ++------------------- example/ios/ExampleTests/DevSupportTests.m | 2 ++ 2 files changed, 4 insertions(+), 19 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a52632513..b63fe558b 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -373,7 +373,7 @@ jobs: with: project-directory: macos working-directory: example - - name: Build x86 + - name: Build if: ${{ steps.affected.outputs.macos != '' }} run: | ../scripts/build/xcodebuild.sh macos/Example.xcworkspace build-for-testing @@ -384,27 +384,10 @@ jobs: node --test test/config.test.mjs working-directory: example - name: Test - # Temporarily disabled due to random failures - if: false # ${{ steps.affected.outputs.macos != '' && github.event_name != 'schedule' }} + if: ${{ steps.affected.outputs.macos != '' && github.event_name != 'schedule' }} run: | ../scripts/build/xcodebuild.sh macos/Example.xcworkspace test-without-building working-directory: example - - name: Prepare for arm64 build - if: ${{ steps.affected.outputs.macos != '' }} - run: | - rm -fr macos/build - working-directory: example - - name: Install Pods - if: ${{ steps.affected.outputs.macos != '' }} - uses: ./.github/actions/cocoapods - with: - project-directory: macos - working-directory: example - - name: Build arm64 - if: ${{ steps.affected.outputs.macos != '' }} - run: | - ../scripts/build/xcodebuild.sh macos/Example.xcworkspace build ARCHS=arm64 - working-directory: example timeout-minutes: 60 macos-template: name: "macOS [template]" diff --git a/example/ios/ExampleTests/DevSupportTests.m b/example/ios/ExampleTests/DevSupportTests.m index 0ab9b7110..dc9b3abfe 100644 --- a/example/ios/ExampleTests/DevSupportTests.m +++ b/example/ios/ExampleTests/DevSupportTests.m @@ -12,6 +12,8 @@ - (void)testDevSupportIsLinked XCTAssertNotNil(ReactAppDidFinishLaunchingNotification); XCTAssertNotNil(ReactAppWillInitializeReactNativeNotification); XCTAssertNotNil(ReactAppDidInitializeReactNativeNotification); + XCTAssertNotNil(ReactAppRuntimeReadyNotification); + XCTAssertNotNil(ReactAppDidRegisterAppsNotification); XCTAssertNotNil(ReactAppSceneDidOpenURLNotification); }