Skip to content

Commit 293efd9

Browse files
authored
detach playwright-core usage with imports (#5577)
Co-authored-by: Sean Larkin <thelarkinn@users.noreply.github.com>
1 parent 275c3f5 commit 293efd9

3 files changed

Lines changed: 13 additions & 9 deletions

File tree

vscode-extensions/playwright-on-codespaces-vscode-extension/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "playwright-on-codespaces",
3-
"version": "0.0.0",
3+
"version": "0.0.1",
44
"repository": {
55
"type": "git",
66
"url": "https://github.com/microsoft/rushstack.git",

vscode-extensions/playwright-on-codespaces-vscode-extension/src/extension.ts

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,21 @@ import * as os from 'node:os';
55
import * as path from 'node:path';
66
import * as vscode from 'vscode';
77

8+
import type {
9+
TunnelStatus,
10+
IHandshake,
11+
ILaunchOptionsAllowlist,
12+
ILaunchOptionsValidationResult
13+
} from '@rushstack/playwright-browser-tunnel';
14+
15+
import { PlaywrightTunnel } from '@rushstack/playwright-browser-tunnel/lib/PlaywrightBrowserTunnel';
16+
817
import {
9-
PlaywrightTunnel,
10-
type TunnelStatus,
11-
type IHandshake,
1218
EXTENSION_INSTALLED_FILENAME,
13-
LaunchOptionsValidator,
14-
type ILaunchOptionsAllowlist,
15-
type ILaunchOptionsValidationResult,
1619
getNormalizedErrorString
17-
} from '@rushstack/playwright-browser-tunnel';
20+
} from '@rushstack/playwright-browser-tunnel/lib/utilities';
21+
import { LaunchOptionsValidator } from '@rushstack/playwright-browser-tunnel/lib/LaunchOptionsValidator';
22+
1823
import { Terminal, type ITerminal, type ITerminalProvider } from '@rushstack/terminal';
1924

2025
import { runWorkspaceCommandAsync } from '@rushstack/vscode-shared/lib/runWorkspaceCommandAsync';

vscode-extensions/playwright-on-codespaces-vscode-extension/webpack.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ function createConfig({ production, webpack }) {
2020

2121
// Mark problematic modules as externals to avoid webpack bundling issues
2222
const externals = /** @type {Record<string, string>} */ (config.externals || {});
23-
externals['playwright-core'] = 'commonjs playwright-core';
2423
externals['bufferutil'] = 'commonjs bufferutil';
2524
externals['utf-8-validate'] = 'commonjs utf-8-validate';
2625
config.externals = externals;

0 commit comments

Comments
 (0)