UploadObject file opening mode to std::ios::binary

[GitHubLipanpan]

UploadObject 对象中建议把文件打开的模式设置为std::ios::binary，负责在win系统上运行可以回出现文件读取提前截止的问题
翻译为 English

It is recommended to set the file opening mode to std::ios::binary in the UploadObject object. Otherwise, when running on a Windows system, there may be an issue where file reading stops prematurely.

[GitHubLipanpan]

UploadObjectResponse Client::UploadObject(UploadObjectArgs args) {
if (error::Error err = args.Validate()) {
return UploadObjectResponse(err);
}

std::ifstream file;
file.exceptions(std::ifstream::failbit | std::ifstream::badbit);
try {
file.open(args.filename, std::ios::binary);
} catch (std::system_error& err) {
return error::make(
"unable to open file " + args.filename + "; " + err.code().message());
}

[HO-COOH]

I encountered this issue, and found this is fixed in #186 . This is very blocking, and someone please make a release.@balamurugana

[dedmen]

Workaround for now

//minio::s3::UploadObjectResponse resp = client.UploadObject(uArgs);
minio::s3::UploadObjectResponse resp;

{
    if (minio::error::Error err = uArgs.Validate()) {
        return JSValueMakeNull(ctx);
    }

    std::ifstream file;
    file.exceptions(std::ifstream::failbit | std::ifstream::badbit);
    try {
        file.open(uArgs.filename, std::ios_base::binary);
    }
    catch (std::system_error& err) {
        //return minio::error::make<minio::s3::UploadObjectResponse>("unable to open file " + uArgs.filename + "; " + err.code().message());
        return JSValueMakeNull(ctx);
    }

    minio::s3::PutObjectArgs po_args(file, uArgs.object_size, 0);
    po_args.extra_headers = std::move(uArgs.extra_headers);
    po_args.extra_query_params = std::move(uArgs.extra_query_params);
    po_args.bucket = std::move(uArgs.bucket);
    po_args.region = std::move(uArgs.region);
    po_args.object = std::move(uArgs.object);
    po_args.headers = std::move(uArgs.headers);
    po_args.user_metadata = std::move(uArgs.user_metadata);
    po_args.sse = std::move(uArgs.sse);
    po_args.tags = std::move(uArgs.tags);
    po_args.retention = std::move(uArgs.retention);
    po_args.legal_hold = std::move(uArgs.legal_hold);
    po_args.content_type = std::move(uArgs.content_type);
    po_args.progressfunc = std::move(uArgs.progressfunc);
    po_args.progress_userdata = std::move(uArgs.progress_userdata);

    minio::s3::PutObjectResponse respA = client.PutObject(std::move(po_args));
    file.close();
    resp = minio::s3::UploadObjectResponse(respA);
}