Allow expanding diff window to see neighboring code

[QuentinTorg]

What do you want to change?

I would like to be able to click above/below the hunk to expand the window and see more code context around the existing code. If the expansion would merge up to another hunk, then it merges the hunks. Github PR reviews have this feature for reference

Why?

Sometimes the hunk is too small and only shows few lines inside of a large function. This can make it hard to review, especially if there are multiple changes to a single function that are then broken into multiple hunks.

How? (optional)

No response

[benvinegar]

@QuentinTorg I think it does that? There are little ^ carets next to the code. (It can be better, don't get me wrong.)

[QuentinTorg]

I see what you're talking about, and it does work well enough.

Above and below hunk, it says "XXX unchanged lines". when I click anywhere in that bar, it expands all of those unchanged lines

What github does that is a bit different, and pretty nice IMO. When I click the expansion button, it only expands like 10-20 lines above that hunk so I can see the start of the function. It allows me to click multiple times if I want to expand more. This is nice when the distance to the next diff (or beginning of file) is hundreds of lines

I'm not saying one is more right than the other, but it would definitely be nice to have an option for either

Additionally, just from a UI perspective it would be nice if when hovering over the expansion tab there was some indication that it was clickable, like bouncing/showing the carat (similar to how the + shows up for commenting on the selected line)

[QuentinTorg]

idk what is best for bookkeeping. Should I make a new issue for doing a limited expansion instead of expanding to next hunk?

[benvinegar]

Yeah I think that would be more accurate/ideal