Logger_config - actual output location is not consistent

[simonyg]

No Path

Using this logging configuration with relative log path in the agent.cfg:

logger_config
{
   output = file agent.log
}

the location of the agent.cfg is <location>.

Expect: all the log files are in <location>

Case 1:

run the command at <location>
agent run

Found agent.log and the archive files agent_YYYY-MM-DD_HH-MM-SS_xx.log in <location> - GOOD

Case 2:

install it as service by running the command at <location>
agent install

Found agent.log and its archive file in the location of agent.exe and also at <location>

the archive file at <location> is likely created by the agent install process.

=====================================================

Absolute Path

Using this logging configuration with relative log path in the agent.cfg:

logger_config
{
   output = file c:\logs\agent.log
}

the location of the agent.cfg is <location>.

Expect: all the log files are in c:\logs

Case 1:

run the command at <location>
agent run

Found agent.log in c:\logs but the archive files agent_YYYY-MM-DD_HH-MM-SS_xx.log in <location>

case 2:

install it as service by running the command at <location>
agent install

Found agent.log in c:\logs but the archive files agent_YYYY-MM-DD_HH-MM-SS_xx.log in <location>

the archive file at <location> is likely created by the agent install process. No new archive can be found.

=====================================================

Relative Path

Using this logging configuration with relative log path in the agent.cfg:

logger_config
{
   output = file .\logs\agent.log
}

the location of the agent.cfg is .

Expect: all the log files are in \logs

Case 1:

run the command at <location>
agent run

Found agent.log in <location>\logs but the archive files agent_YYYY-MM-DD_HH-MM-SS_xx.log in <location>

case 2:

install it as service by running the command at <location>
agent install

Found empty <location>\logs directory, an archive file agent_YYYY-MM-DD_HH-MM-SS_xx.log in <location>, agent.log at <location of agent.exe>\logs, archive file agent_YYYY-MM-DD_HH-MM-SS_xx.log at <location of agent.exe>

[wsobel]

The issue is when the log directory gets setup for archive rollover and placement.

    // If the file name does not specify a log directory, use the
    // archive directory
    logFileName = fs::path(file_name);
    if (!logFileName.has_parent_path())
      logFileName = logDirectory / logFileName;
    else if (logFileName.is_relative())
      logFileName = fs::current_path() / logFileName;

The absolute path works for the file, but if it is relative, it uses the fs::current_path(). CWD is set to the agent.exe directory.

The behavior should be to set the log directory by default to the directory of the configuration file and then archive all the files in that directory.

I will change the behavior and we can test.

[wsobel]

Made changes to the logger and the handling of the storage of the backup files. The log directory is now derived as follows:

The default directory is the same directory the agent.cfg file is in.
If the log file has a relative or absolute path, that is used as a default path for both the log and archive files
Otherwise, if the archive file pattern has an absolute or relative path that is used as the log directory.

If the archive pattern has an absolute path, the archive files will always go in that directory.

The agent will automatically create directories if they do not exist.

Tested with the following:

logger_config {
  archive_pattern = C:\Logging Directory With Spaces\Logging\agent_%Y-%m-%d_%H-%M-%S.log
  rotation_size = 10k
  level = trace
}

logger_config {
  file_name = C:\Logging Directory With Spaces\Logging\agent.log
  rotation_size = 10k
  level = trace
}

logger_config {
  file_name = ./log/agent.log
  rotation_size = 10k
  level = trace
}

logger_config {
  output = file ./log/agent.log
  rotation_size = 10k
  level = trace
}

One note, the output legacy file spec does not support spaces. Use file_name instead.