From b78bc76747c36e90fb900361db1277f890bb4fce Mon Sep 17 00:00:00 2001 From: Marcel Klehr Date: Thu, 16 Jul 2026 14:20:15 +0200 Subject: [PATCH 1/3] fix(SetupChecks): Link to task processing worker docs Signed-off-by: Marcel Klehr --- .../lib/SetupChecks/TaskProcessingWorkerIsRunning.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/settings/lib/SetupChecks/TaskProcessingWorkerIsRunning.php b/apps/settings/lib/SetupChecks/TaskProcessingWorkerIsRunning.php index e480d6765c955..09c3f04203a88 100644 --- a/apps/settings/lib/SetupChecks/TaskProcessingWorkerIsRunning.php +++ b/apps/settings/lib/SetupChecks/TaskProcessingWorkerIsRunning.php @@ -63,12 +63,14 @@ public function run(): SetupResult { if ($lastIteration > 0) { return SetupResult::warning( - $this->l10n->t('The Task Processing worker does not seem to be running. The last run was at %s.', [date('Y-m-d H:i:s', $lastIteration)]) + $this->l10n->t('The Task Processing worker does not seem to be running. The last run was at %s.', [date('Y-m-d H:i:s', $lastIteration)]), + linkToDoc: 'https://docs.nextcloud.com/server/latest/admin_manual/ai/overview.html#improve-ai-task-pickup-speed' ); } return SetupResult::warning( - $this->l10n->t('The Task Processing worker does not seem to be running. It seems it has never run so far.') + $this->l10n->t('The Task Processing worker does not seem to be running. It seems it has never run so far.'), + linkToDoc: 'https://docs.nextcloud.com/server/latest/admin_manual/ai/overview.html#improve-ai-task-pickup-speed' ); } } From ef1d47583917568d4eead8361355c02569240bcd Mon Sep 17 00:00:00 2001 From: Marcel Klehr Date: Wed, 22 Jul 2026 15:35:12 +0200 Subject: [PATCH 2/3] fix: Use url generator to link to docs Signed-off-by: Marcel Klehr --- .../lib/SetupChecks/TaskProcessingWorkerIsRunning.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/settings/lib/SetupChecks/TaskProcessingWorkerIsRunning.php b/apps/settings/lib/SetupChecks/TaskProcessingWorkerIsRunning.php index 09c3f04203a88..071974ad88925 100644 --- a/apps/settings/lib/SetupChecks/TaskProcessingWorkerIsRunning.php +++ b/apps/settings/lib/SetupChecks/TaskProcessingWorkerIsRunning.php @@ -12,6 +12,7 @@ use OCP\AppFramework\Utility\ITimeFactory; use OCP\IAppConfig; use OCP\IL10N; +use OCP\IURLGenerator; use OCP\SetupCheck\ISetupCheck; use OCP\SetupCheck\SetupResult; use OCP\TaskProcessing\IManager; @@ -26,6 +27,7 @@ public function __construct( private readonly IManager $taskProcessingManager, private readonly ITimeFactory $timeFactory, private readonly IAppConfig $appConfig, + private readonly IURLGenerator $url, ) { } @@ -64,13 +66,13 @@ public function run(): SetupResult { if ($lastIteration > 0) { return SetupResult::warning( $this->l10n->t('The Task Processing worker does not seem to be running. The last run was at %s.', [date('Y-m-d H:i:s', $lastIteration)]), - linkToDoc: 'https://docs.nextcloud.com/server/latest/admin_manual/ai/overview.html#improve-ai-task-pickup-speed' + linkToDoc: $this->url->linkToDocs('admin-ai-pickup-speed'), ); } return SetupResult::warning( $this->l10n->t('The Task Processing worker does not seem to be running. It seems it has never run so far.'), - linkToDoc: 'https://docs.nextcloud.com/server/latest/admin_manual/ai/overview.html#improve-ai-task-pickup-speed' + linkToDoc: $this->url->linkToDocs('admin-ai-pickup-speed'), ); } } From b910c267e864548969455a9d68dbe041ca81cca0 Mon Sep 17 00:00:00 2001 From: Marcel Klehr Date: Thu, 23 Jul 2026 08:52:29 +0200 Subject: [PATCH 3/3] fix: Fix TaskProcessingWorkerIsRunning setup check tests Signed-off-by: Marcel Klehr --- .../tests/SetupChecks/TaskProcessingWorkerIsRunningTest.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/apps/settings/tests/SetupChecks/TaskProcessingWorkerIsRunningTest.php b/apps/settings/tests/SetupChecks/TaskProcessingWorkerIsRunningTest.php index 43df9e599b686..f8d6ff4c4b576 100644 --- a/apps/settings/tests/SetupChecks/TaskProcessingWorkerIsRunningTest.php +++ b/apps/settings/tests/SetupChecks/TaskProcessingWorkerIsRunningTest.php @@ -12,6 +12,7 @@ use OCP\AppFramework\Utility\ITimeFactory; use OCP\IAppConfig; use OCP\IL10N; +use OCP\IURLGenerator; use OCP\SetupCheck\SetupResult; use OCP\TaskProcessing\IManager; use OCP\TaskProcessing\Task; @@ -23,6 +24,7 @@ class TaskProcessingWorkerIsRunningTest extends TestCase { private ITimeFactory&MockObject $timeFactory; private IManager&MockObject $taskProcessingManager; private IAppConfig&MockObject $appConfig; + private IURLGenerator&MockObject $urlGenerator; private TaskProcessingWorkerIsRunning $check; @@ -33,12 +35,14 @@ protected function setUp(): void { $this->timeFactory = $this->getMockBuilder(ITimeFactory::class)->getMock(); $this->taskProcessingManager = $this->getMockBuilder(IManager::class)->getMock(); $this->appConfig = $this->getMockBuilder(IAppConfig::class)->getMock(); + $this->urlGenerator = $this->getMockBuilder(IURLGenerator::class)->getMock(); $this->check = new TaskProcessingWorkerIsRunning( $this->l10n, $this->taskProcessingManager, $this->timeFactory, - $this->appConfig + $this->appConfig, + $this->urlGenerator, ); }