Added timeout parameters to SerialPortConnection constructor

Author: nextroundwinner

README.md

@@ -148,4 +148,7 @@ Python 3.11 or higher
 - Added getter for underlying serial object in SerialPortConnection
 
 ## 0.0.22
-- Library specific exception classes
+- Library specific exception classes
+
+## 0.0.23
+- Added timeout parameters to SerialPortConnection constructor

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "science_mode_4"
-version = "0.0.22"
+version = "0.0.23"
 authors = [
   { name="Marc Hofmann", email="marc-hofmann@gmx.de" },
 ]

src/science_mode_4/utils/serial_port_connection.py

@@ -35,14 +35,20 @@ def list_science_mode_device_ports() -> list[serial.tools.list_ports_common.List
         return filtered_ports
 
 
-    def __init__(self, port: str, error_timeout: int = 3):
-        self._ser = serial.Serial(timeout = 0)
+    def __init__(self, port: str, read_timeout_ins_s: float = 0, write_timeout_ins_s: float = 1, error_timeout_in_s: float = 3):
+        self._ser = serial.Serial(timeout = read_timeout_ins_s, write_timeout=write_timeout_ins_s)
         self._ser.port = port
-        self._error_timeout = error_timeout
+        self._error_timeout_in_s = error_timeout_in_s
 
         self._last_written_data = bytes()
 
 
+    @property
+    def internal_serial(self) -> serial.Serial:
+        """Getter for internal pySerial object"""
+        return self._ser
+
+
     def open(self):
         self._ser.open()
 
@@ -92,7 +98,7 @@ def _read_intern(self) -> bytes:
             except Exception: # pylint:disable=broad-exception-caught
                 pass
 
-            time.sleep(self._error_timeout)
+            time.sleep(self._error_timeout_in_s)
 
             try:
                 self.open()