fixup after review

marcopiraccini · marcopiraccini · commit 15f91f96ccbd · 2026-04-09T12:28:07.000+02:00
Signed-off-by: marcopiraccini &lt;marco.piraccini@gmail.com&gt;
diff --git a/src/node_options.cc b/src/node_options.cc
@@ -2114,8 +2114,9 @@ void ParseNodeOptionsEnvVarBinding(const FunctionCallbackInfo<Value>& args) {
   }
 
   Local<Value> v8_result;
-  CHECK(ToV8Value(context, result).ToLocal(&v8_result));
-  args.GetReturnValue().Set(v8_result);
+  if (ToV8Value(context, result).ToLocal(&v8_result)) {
+    args.GetReturnValue().Set(v8_result);
+  }
 }
 
 void Initialize(Local<Object> target,

Original file line number	Diff line number	Diff line change
`@@ -2114,8 +2114,9 @@ void ParseNodeOptionsEnvVarBinding(const FunctionCallbackInfo<Value>& args) {`
`2114`	`2114`	`}`
`2115`	`2115`
`2116`	`2116`	`Local<Value> v8_result;`
`2117`		`- CHECK(ToV8Value(context, result).ToLocal(&v8_result));`
`2118`		`- args.GetReturnValue().Set(v8_result);`
	`2117`	`+ if (ToV8Value(context, result).ToLocal(&v8_result)) {`
	`2118`	`+ args.GetReturnValue().Set(v8_result);`
	`2119`	`+ }`
`2119`	`2120`	`}`
`2120`	`2121`
`2121`	`2122`	`void Initialize(Local<Object> target,`