Skip to content

Commit bab3d28

Browse files
Copilothotlong
andcommitted
Fix package dependencies and TypeScript errors
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent 8ed86de commit bab3d28

6 files changed

Lines changed: 17 additions & 10 deletions

File tree

examples/basic/logger-example.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ async function examplePluginLogging() {
182182
dependencies: ['database'],
183183

184184
init: async (ctx: PluginContext) => {
185-
const db = ctx.getService('db');
185+
const db = ctx.getService('db') as any;
186186
ctx.logger.info('API plugin initialized', { dbConnected: db.connected });
187187

188188
ctx.registerService('api', { server: 'http://localhost:3000' });

examples/basic/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
"typecheck": "tsc --noEmit"
1010
},
1111
"dependencies": {
12-
"@objectstack/spec": "workspace:*"
12+
"@objectstack/spec": "workspace:*",
13+
"@objectstack/core": "workspace:*"
1314
},
1415
"devDependencies": {
1516
"typescript": "^5.0.0",

packages/client/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
"build": "tsc"
99
},
1010
"dependencies": {
11-
"@objectstack/spec": "workspace:*"
11+
"@objectstack/spec": "workspace:*",
12+
"@objectstack/core": "workspace:*"
1213
},
1314
"devDependencies": {
1415
"typescript": "^5.0.0"

packages/objectql/src/engine.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,7 @@ export class ObjectQL implements IDataEngine {
171171
this.drivers.set(driver.name, driver);
172172
this.logger.info('Registered driver', {
173173
driverName: driver.name,
174-
version: driver.version,
175-
capabilities: driver.supports || 'none'
174+
version: driver.version
176175
});
177176

178177
if (isDefault || this.drivers.size === 1) {

packages/objectql/src/plugin.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export class ObjectQLPlugin implements Plugin {
2727
}
2828

2929
ctx.registerService('objectql', this.ql);
30-
if(ctx.logger) ctx.logger.log(`[ObjectQLPlugin] ObjectQL engine registered as service`);
30+
ctx.logger.info('ObjectQL engine registered as service');
3131

3232
// Register Protocol Implementation
3333
if (!this.ql) {
@@ -36,11 +36,11 @@ export class ObjectQLPlugin implements Plugin {
3636
const protocolShim = new ObjectStackProtocolImplementation(this.ql);
3737

3838
ctx.registerService('protocol', protocolShim);
39-
if(ctx.logger) ctx.logger.log(`[ObjectQLPlugin] Protocol service registered`);
39+
ctx.logger.info('Protocol service registered');
4040
}
4141

4242
async start(ctx: PluginContext) {
43-
if(ctx.logger) ctx.logger.log(`[ObjectQLPlugin] ObjectQL engine initialized`);
43+
ctx.logger.info('ObjectQL engine initialized');
4444

4545
// Discover features from Kernel Services
4646
if (ctx.getServices && this.ql) {
@@ -49,12 +49,12 @@ export class ObjectQLPlugin implements Plugin {
4949
if (name.startsWith('driver.')) {
5050
// Register Driver
5151
this.ql.registerDriver(service);
52-
if(ctx.logger) ctx.logger.log(`[ObjectQLPlugin] Discovered and registered driver service: ${name}`);
52+
ctx.logger.debug('Discovered and registered driver service', { serviceName: name });
5353
}
5454
if (name.startsWith('app.')) {
5555
// Register App
5656
this.ql.registerApp(service); // service is Manifest
57-
if(ctx.logger) ctx.logger.log(`[ObjectQLPlugin] Discovered and registered app service: ${name}`);
57+
ctx.logger.debug('Discovered and registered app service', { serviceName: name });
5858
}
5959
}
6060
}

pnpm-lock.yaml

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)