address reviews

JoaoBraveCoding · JoaoBraveCoding · commit 722a125c18d9 · 2026-03-30T15:40:34.000+01:00
diff --git a/authentication/oidc.go b/authentication/oidc.go
@@ -104,10 +104,6 @@ func newOIDCAuthenticator(c map[string]interface{}, tenant string,
 		for {
 			block, rest = pem.Decode(rest)
 			if block == nil {
-				if len(config.issuerCAs) == 0 {
-					return nil, fmt.Errorf("failed to parse issuer CA certificate PEM")
-				}
-
 				break
 			}
 
@@ -118,6 +114,10 @@ func newOIDCAuthenticator(c map[string]interface{}, tenant string,
 
 			config.issuerCAs = append(config.issuerCAs, cert)
 		}
+
+		if len(config.issuerCAs) == 0 {
+			return nil, fmt.Errorf("failed to parse issuer CA certificate PEM")
+		}
 	}
 
 	t := &http.Transport{

Original file line number	Diff line number	Diff line change
`@@ -104,10 +104,6 @@ func newOIDCAuthenticator(c map[string]interface{}, tenant string,`
`104`	`104`	`for {`
`105`	`105`	`block, rest = pem.Decode(rest)`
`106`	`106`	`if block == nil {`
`107`		`- if len(config.issuerCAs) == 0 {`
`108`		`- return nil, fmt.Errorf("failed to parse issuer CA certificate PEM")`
`109`		`- }`
`110`		`-`
`111`	`107`	`break`
`112`	`108`	`}`
`113`	`109`
`@@ -118,6 +114,10 @@ func newOIDCAuthenticator(c map[string]interface{}, tenant string,`
`118`	`114`
`119`	`115`	`config.issuerCAs = append(config.issuerCAs, cert)`
`120`	`116`	`}`
	`117`	`+`
	`118`	`+ if len(config.issuerCAs) == 0 {`
	`119`	`+ return nil, fmt.Errorf("failed to parse issuer CA certificate PEM")`
	`120`	`+ }`
`121`	`121`	`}`
`122`	`122`
`123`	`123`	`t := &http.Transport{`