Skip to content

Commit 83158e3

Browse files
committed
PullRequest: 60 chore: fix some comment
Merge branch fix_comment of git@code.alipay.com:oceanbase/OBShell-SDK-Python.git into master https://code.alipay.com/oceanbase/OBShell-SDK-Python/pull_requests/60 Signed-off-by: 雪染 <xin.sunhx@oceanbase.com> * chore: fix some comment
1 parent bca935a commit 83158e3

1 file changed

Lines changed: 6 additions & 9 deletions

File tree

obshell/service/client_v1.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2479,8 +2479,8 @@ def add_obproxy_sync(
24792479
home_path (str): The home path of the obproxy.
24802480
app_name (str): The name of the application.
24812481
sql_port (int, optional): The SQL port of the obproxy. Defaults to 2883.
2482-
rpc_port (int, optional): The RPC port of the obproxy. Defaults to 2884.
2483-
exporter_port (int, optional): The exporter port of the obproxy. Defaults to 2885.
2482+
exporter_port (int, optional): The exporter port of the obproxy. Defaults to 2884.
2483+
rpc_port (int, optional): The RPC port of the obproxy. Defaults to 2885.
24842484
rs_list (list, optional): The list of the rs.
24852485
config_url (str, optional): The URL of the config.
24862486
proxyro_passwword (str, optional): The password of proxyro user.
@@ -2511,8 +2511,8 @@ def add_obproxy(
25112511
home_path (str): The home path of the obproxy.
25122512
app_name (str): The name of the application.
25132513
sql_port (int, optional): The SQL port of the obproxy. Defaults to 2883.
2514-
rpc_port (int, optional): The RPC port of the obproxy. Defaults to 2884.
2515-
exporter_port (int, optional): The exporter port of the obproxy. Defaults to 2885.
2514+
exporter_port (int, optional): The exporter port of the obproxy. Defaults to 2884.
2515+
rpc_port (int, optional): The RPC port of the obproxy. Defaults to 2885.
25162516
rs_list (list, optional): The list of the rs.
25172517
config_url (str, optional): The URL of the config.
25182518
proxyro_password (str, optional): The password of proxyro user.
@@ -2581,9 +2581,6 @@ def delete_obproxy_sync(self):
25812581
"""Deletes the obproxy.
25822582
25832583
Deletes the obproxy.
2584-
2585-
Args:
2586-
clean_dir (bool, optional): Whether to delete the obproxy directory. Defaults to False.
25872584
"""
25882585
dag = self.delete_obproxy()
25892586
return None if dag is None else self.wait_dag_succeed(dag.generic_id)
@@ -2596,7 +2593,7 @@ def upgrade_obproxy(self, version: str, release: str, upgrade_dir: str = ""):
25962593
Args:
25972594
version (str): The version of the obproxy.
25982595
release (str): The release of the obproxy.
2599-
upgrade_dir (str, optional): The directory of the obproxy. Defaults to "".
2596+
upgrade_dir (str, optional): the temp dir used by the task.
26002597
"""
26012598
data = {
26022599
'version': version,
@@ -2615,7 +2612,7 @@ def upgrade_obproxy_sync(self, version: str, release: str, upgrade_dir: str = ""
26152612
Args:
26162613
version (str): The version of the obproxy.
26172614
release (str): The release of the obproxy.
2618-
upgrade_dir (str, optional): The directory of the obproxy. Defaults to "".
2615+
upgrade_dir (str, optional): the temp dir used by the task.
26192616
"""
26202617
dag = self.upgrade_obproxy(version, release, upgrade_dir)
26212618
return self.wait_dag_succeed(dag.generic_id)

0 commit comments

Comments
 (0)