Skip to content

Commit 5dfdfd9

Browse files
Address event handler review feedback
Signed-off-by: Lucas-FManager <265058144+Lucas-FManager@users.noreply.github.com>
1 parent fb4e9a1 commit 5dfdfd9

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

openfeature/_event_support.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
from openfeature.client import OpenFeatureClient
1919

2020

21-
_logger = getLogger(__name__)
21+
logger = getLogger("openfeature")
2222
_event_executor = ThreadPoolExecutor(thread_name_prefix="openfeature-event-handler")
2323

2424
_global_lock = threading.RLock()
@@ -127,7 +127,7 @@ def _run_handler(handler: EventHandler, details: EventDetails) -> None:
127127
try:
128128
handler(details)
129129
except Exception:
130-
_logger.exception("Unhandled exception in OpenFeature event handler")
130+
logger.exception("Unhandled exception in OpenFeature event handler")
131131

132132

133133
def clear() -> None:

tests/test_client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -580,8 +580,7 @@ def test_provider_event_handler_exception_does_not_stop_subsequent_handlers():
580580
spy = MagicMock()
581581
handler_called = threading.Event()
582582

583-
def raising_handler(details):
584-
raise RuntimeError("handler failed")
583+
raising_handler = MagicMock(side_effect=RuntimeError("handler failed"))
585584

586585
def recording_handler(details):
587586
spy.provider_error(details)
@@ -601,6 +600,7 @@ def recording_handler(details):
601600

602601
# Then
603602
assert handler_called.wait(timeout=1)
603+
raising_handler.assert_called_once_with(expected_details)
604604
spy.provider_error.assert_called_once_with(expected_details)
605605

606606

0 commit comments

Comments
 (0)