This method is experimental so not public. You may reflectively call it using {@link - * OpenTelemetrySdkBuilderUtil#setConfigProvider(OpenTelemetrySdkBuilder, SdkConfigProvider)}. + * OpenTelemetrySdkBuilderUtil#setConfigProvider(OpenTelemetrySdkBuilder, + * io.opentelemetry.sdk.internal.SdkConfigProvider)}. + * + *
The parameter type is {@link Object} to avoid introducing another direct incubator-linked + * method signature in the path Groovy eagerly inspects. */ - OpenTelemetrySdkBuilder setConfigProvider(SdkConfigProvider configProvider) { + OpenTelemetrySdkBuilder setConfigProvider(Object configProvider) { this.configProvider = requireNonNull(configProvider); return this; } @@ -143,7 +160,47 @@ public OpenTelemetrySdk build() { OpenTelemetrySdk openTelemetrySdk = new OpenTelemetrySdk(tracerProvider, meterProvider, loggerProvider, propagators); return INCUBATOR_AVAILABLE - ? IncubatingUtil.createExtendedOpenTelemetrySdk(openTelemetrySdk, configProvider) + ? createExtendedOpenTelemetrySdk(openTelemetrySdk, configProvider) : openTelemetrySdk; } + + private static OpenTelemetrySdk createExtendedOpenTelemetrySdk( + OpenTelemetrySdk openTelemetrySdk, @Nullable Object configProvider) { + return createExtendedOpenTelemetrySdk( + openTelemetrySdk, configProvider, requireNonNull(CREATE_EXTENDED_OPEN_TELEMETRY_SDK_METHOD)); + } + + static OpenTelemetrySdk createExtendedOpenTelemetrySdk( + OpenTelemetrySdk openTelemetrySdk, + @Nullable Object configProvider, + Method createExtendedOpenTelemetrySdkMethod) { + try { + return (OpenTelemetrySdk) + createExtendedOpenTelemetrySdkMethod.invoke(null, openTelemetrySdk, configProvider); + } catch (IllegalAccessException e) { + throw new IllegalStateException( + "IncubatingUtil.createExtendedOpenTelemetrySdk could not be invoked." + + " This is a bug in OpenTelemetry.", + e); + } catch (IllegalArgumentException e) { + throw new IllegalStateException( + "IncubatingUtil.createExtendedOpenTelemetrySdk could not be called with the expected" + + " arguments. This is a bug in OpenTelemetry.", + e); + } catch (InvocationTargetException e) { + Throwable cause = e.getTargetException(); + // Preserve the original application behavior rather than wrapping runtime failures emitted + // by the incubator path in a reflective InvocationTargetException. + if (cause instanceof RuntimeException) { + throw (RuntimeException) cause; + } + if (cause instanceof Error) { + throw (Error) cause; + } + throw new IllegalStateException( + "IncubatingUtil.createExtendedOpenTelemetrySdk failed." + + " This is a bug in OpenTelemetry.", + cause); + } + } } diff --git a/sdk/all/src/main/java/io/opentelemetry/sdk/internal/OpenTelemetrySdkBuilderUtil.java b/sdk/all/src/main/java/io/opentelemetry/sdk/internal/OpenTelemetrySdkBuilderUtil.java index ff017d64fc0..f34b645eea7 100644 --- a/sdk/all/src/main/java/io/opentelemetry/sdk/internal/OpenTelemetrySdkBuilderUtil.java +++ b/sdk/all/src/main/java/io/opentelemetry/sdk/internal/OpenTelemetrySdkBuilderUtil.java @@ -27,8 +27,7 @@ public static OpenTelemetrySdkBuilder setConfigProvider( OpenTelemetrySdkBuilder builder, SdkConfigProvider configProvider) { try { Method method = - OpenTelemetrySdkBuilder.class.getDeclaredMethod( - "setConfigProvider", SdkConfigProvider.class); + OpenTelemetrySdkBuilder.class.getDeclaredMethod("setConfigProvider", Object.class); method.setAccessible(true); method.invoke(builder, configProvider); } catch (NoSuchMethodException | IllegalAccessException | InvocationTargetException e) { diff --git a/sdk/all/src/test/java/io/opentelemetry/sdk/OpenTelemetrySdkTest.java b/sdk/all/src/test/java/io/opentelemetry/sdk/OpenTelemetrySdkTest.java index c6a48a0dbad..35f07e2e71f 100644 --- a/sdk/all/src/test/java/io/opentelemetry/sdk/OpenTelemetrySdkTest.java +++ b/sdk/all/src/test/java/io/opentelemetry/sdk/OpenTelemetrySdkTest.java @@ -14,6 +14,7 @@ import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; +import groovy.lang.GroovyClassLoader; import io.github.netmikey.logunit.api.LogCapturer; import io.opentelemetry.api.GlobalOpenTelemetry; import io.opentelemetry.api.OpenTelemetry; @@ -39,8 +40,10 @@ import io.opentelemetry.sdk.trace.export.SimpleSpanProcessor; import io.opentelemetry.sdk.trace.export.SpanExporter; import io.opentelemetry.sdk.trace.samplers.Sampler; +import java.lang.reflect.Method; import java.time.Duration; import java.util.concurrent.TimeUnit; +import javax.annotation.Nullable; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -138,6 +141,126 @@ void builder() { assertThat(openTelemetry.getPropagators()).isEqualTo(propagators); } + @Test + void buildFromGroovyWithoutIncubator() throws Exception { + try (GroovyClassLoader groovyClassLoader = new GroovyClassLoader(getClass().getClassLoader())) { + Class groovyClass = + groovyClassLoader.parseClass( + "import io.opentelemetry.sdk.OpenTelemetrySdk\n" + + "class GroovyBuilderCaller {\n" + + " static Object buildSdk() {\n" + + " OpenTelemetrySdk.builder().build()\n" + + " }\n" + + "}\n"); + + assertThat(groovyClass.getMethod("buildSdk").invoke(null)) + .isInstanceOf(OpenTelemetrySdk.class); + } + } + + @Test + void createExtendedOpenTelemetrySdk_rethrowsRuntimeException() throws Exception { + Method method = + OpenTelemetrySdkTest.class.getDeclaredMethod( + "throwRuntimeException", OpenTelemetrySdk.class, Object.class); + + assertThatThrownBy( + () -> + OpenTelemetrySdkBuilder.createExtendedOpenTelemetrySdk( + OpenTelemetrySdk.builder().build(), null, method)) + .isInstanceOf(IllegalStateException.class) + .hasMessage("runtime boom"); + } + + @Test + void createExtendedOpenTelemetrySdk_rethrowsError() throws Exception { + Method method = + OpenTelemetrySdkTest.class.getDeclaredMethod( + "throwError", OpenTelemetrySdk.class, Object.class); + + assertThatThrownBy( + () -> + OpenTelemetrySdkBuilder.createExtendedOpenTelemetrySdk( + OpenTelemetrySdk.builder().build(), null, method)) + .isInstanceOf(AssertionError.class) + .hasMessage("error boom"); + } + + @Test + void createExtendedOpenTelemetrySdk_wrapsCheckedException() throws Exception { + Method method = + OpenTelemetrySdkTest.class.getDeclaredMethod( + "throwCheckedException", OpenTelemetrySdk.class, Object.class); + + assertThatThrownBy( + () -> + OpenTelemetrySdkBuilder.createExtendedOpenTelemetrySdk( + OpenTelemetrySdk.builder().build(), null, method)) + .isInstanceOf(IllegalStateException.class) + .hasMessage( + "IncubatingUtil.createExtendedOpenTelemetrySdk failed. This is a bug in OpenTelemetry.") + .cause() + .isInstanceOf(Exception.class) + .hasMessage("checked boom"); + } + + @Test + void createExtendedOpenTelemetrySdk_wrapsIllegalArgumentException() throws Exception { + Method method = OpenTelemetrySdkTest.class.getDeclaredMethod("wrongSignature", String.class); + + assertThatThrownBy( + () -> + OpenTelemetrySdkBuilder.createExtendedOpenTelemetrySdk( + OpenTelemetrySdk.builder().build(), null, method)) + .isInstanceOf(IllegalStateException.class) + .hasMessage( + "IncubatingUtil.createExtendedOpenTelemetrySdk could not be called with the expected" + + " arguments. This is a bug in OpenTelemetry.") + .cause() + .isInstanceOf(IllegalArgumentException.class); + } + + @Test + void createExtendedOpenTelemetrySdk_wrapsIllegalAccessException() throws Exception { + Method method = + OpenTelemetrySdkTest.class.getDeclaredMethod( + "privateNoAccess", OpenTelemetrySdk.class, Object.class); + + assertThatThrownBy( + () -> + OpenTelemetrySdkBuilder.createExtendedOpenTelemetrySdk( + OpenTelemetrySdk.builder().build(), null, method)) + .isInstanceOf(IllegalStateException.class) + .hasMessage( + "IncubatingUtil.createExtendedOpenTelemetrySdk could not be invoked. This is a bug in OpenTelemetry.") + .cause() + .isInstanceOf(IllegalAccessException.class); + } + + static OpenTelemetrySdk throwRuntimeException( + OpenTelemetrySdk openTelemetrySdk, @Nullable Object configProvider) { + throw new IllegalStateException("runtime boom"); + } + + static OpenTelemetrySdk throwError( + OpenTelemetrySdk openTelemetrySdk, @Nullable Object configProvider) { + throw new AssertionError("error boom"); + } + + static OpenTelemetrySdk throwCheckedException( + OpenTelemetrySdk openTelemetrySdk, @Nullable Object configProvider) throws Exception { + throw new Exception("checked boom"); + } + + static OpenTelemetrySdk wrongSignature(String ignored) { + return null; + } + + private static OpenTelemetrySdk privateNoAccess( + OpenTelemetrySdk openTelemetrySdk, @Nullable Object configProvider) { + return openTelemetrySdk; + } + @Test void getTracer() { assertThat(GlobalOpenTelemetry.getTracer("testTracer1"))