new blog on upcoming changes for weighted graph models#1259
Open
tylernix wants to merge 6 commits into
Open
Conversation
Contributor
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughA new blog post announces OpenFGA's rollout of weighted graph-based Check resolution. It contrasts the legacy recursive approach with build-time graph construction, details breaking changes in model validation and Check behavior, and provides migration guidance including error scenarios, validation checklists, timeline, and community resources. ChangesWeighted Graph Migration Announcement
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@blog/weighted-graph-upcoming-changes.md`:
- Line 14: Change the wording for clarity in the file's intro and model-error
sentence: replace the phrase “update algorithm” with “updated algorithm” in the
sentence that begins “OpenFGA is continuing to roll out a **weighted graph-based
resolution algorithm**…” and change the verb usage “models fallback” (around
line referencing model errors) to “models fall back” or “models revert to the
legacy algorithm” so the phrasing reads naturally and consistently.
- Around line 143-146: The fenced code blocks containing example calls like
check("document:report", "viewer", "document:contract#owner"),
check("document:readme", "viewer", "user:*"), check("document:report", "viewer",
"user:alice"), the blocks with write(document:source#allowed, viewer,
document:target), and the other examples are missing language identifiers;
update each triple-backtick fence to include a language (e.g., ```text) so lint
rule MD040 is satisfied and syntax highlighting works, ensuring you modify every
block that wraps calls to check(...) and write(...) as noted in the review.
- Line 234: Update the heading text "How to Check If You're Model Is Affected"
to use the possessive form by replacing "You're" with "Your" so it reads "How to
Check If Your Model Is Affected"; locate and edit the heading string in the
markdown (the line containing that exact heading) to correct the typo.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f9957dc6-a926-445e-974f-d4af69cc4a72
📒 Files selected for processing (1)
blog/weighted-graph-upcoming-changes.md
Contributor
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new blog post describing OpenFGA’s upcoming weighted graph-based Check resolution changes, the incompatible modeling/check patterns, and migration guidance.
Changes:
- Introduces a new announcement/migration blog post.
- Documents five affected patterns with examples and suggested fixes.
- Adds timeline and support links for users preparing migrations.
Comments suppressed due to low confidence (9)
blog/weighted-graph-upcoming-changes.md:69
- OpenFGA model snippets elsewhere use
dsl.openfgafences for site syntax highlighting (for example, blog/conditional-tuples-announcement.md:23 and docs/content/getting-started/perform-list-users.mdx:100). Using plaindslhere deviates from that convention and may lose OpenFGA-specific highlighting.
```dsl
blog/weighted-graph-upcoming-changes.md:80
- OpenFGA model snippets elsewhere use
dsl.openfgafences for site syntax highlighting (for example, blog/conditional-tuples-announcement.md:23 and docs/content/getting-started/perform-list-users.mdx:100). Using plaindslhere deviates from that convention and may lose OpenFGA-specific highlighting.
```dsl
blog/weighted-graph-upcoming-changes.md:97
- OpenFGA model snippets elsewhere use
dsl.openfgafences for site syntax highlighting (for example, blog/conditional-tuples-announcement.md:23 and docs/content/getting-started/perform-list-users.mdx:100). Using plaindslhere deviates from that convention and may lose OpenFGA-specific highlighting.
```dsl
blog/weighted-graph-upcoming-changes.md:106
- OpenFGA model snippets elsewhere use
dsl.openfgafences for site syntax highlighting (for example, blog/conditional-tuples-announcement.md:23 and docs/content/getting-started/perform-list-users.mdx:100). Using plaindslhere deviates from that convention and may lose OpenFGA-specific highlighting.
```dsl
blog/weighted-graph-upcoming-changes.md:117
- OpenFGA model snippets elsewhere use
dsl.openfgafences for site syntax highlighting (for example, blog/conditional-tuples-announcement.md:23 and docs/content/getting-started/perform-list-users.mdx:100). Using plaindslhere deviates from that convention and may lose OpenFGA-specific highlighting.
```dsl
blog/weighted-graph-upcoming-changes.md:135
- OpenFGA model snippets elsewhere use
dsl.openfgafences for site syntax highlighting (for example, blog/conditional-tuples-announcement.md:23 and docs/content/getting-started/perform-list-users.mdx:100). Using plaindslhere deviates from that convention and may lose OpenFGA-specific highlighting.
```dsl
blog/weighted-graph-upcoming-changes.md:150
- OpenFGA model snippets elsewhere use
dsl.openfgafences for site syntax highlighting (for example, blog/conditional-tuples-announcement.md:23 and docs/content/getting-started/perform-list-users.mdx:100). Using plaindslhere deviates from that convention and may lose OpenFGA-specific highlighting.
```dsl
blog/weighted-graph-upcoming-changes.md:184
- OpenFGA model snippets elsewhere use
dsl.openfgafences for site syntax highlighting (for example, blog/conditional-tuples-announcement.md:23 and docs/content/getting-started/perform-list-users.mdx:100). Using plaindslhere deviates from that convention and may lose OpenFGA-specific highlighting.
```dsl
blog/weighted-graph-upcoming-changes.md:256
- This sentence is missing the article before "weighted graph algorithm"; it should read "the weighted graph algorithm".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ``` | ||
| write(document:source#allowed, viewer, document:target) # Already stored | ||
| write(document:source#reader, viewer, document:target) # Store explicitly |
Comment on lines
+115
to
+117
| **Fix:** Split into a "base" relation (allows recursion) and an "allowed" relation (applies the access gate): | ||
|
|
||
| ```dsl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary by CodeRabbit
Release Notes