Skip to content

Commit 83af048

Browse files
Merge pull request #94 from dmaizel/fix_drain
Flag --delete-local-data has been deprecated
2 parents 84778aa + 842bd9d commit 83af048

3 files changed

Lines changed: 18 additions & 3 deletions

File tree

ansible/rebuild_module.digest

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
71d90677f027d025a625c5289c4a07c3 -
1+
45f9e2d975653872e1db035f800f314b -

ansible/roles/openshift_client_python/library/openshift_client_python.py

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/openshift/base_verbs.py

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,22 @@ def drain_node(apiobj_node_name_or_qname, ignore_daemonsets=True,
293293
base_args.append('--ignore-daemonsets')
294294

295295
if delete_local_data:
296-
base_args.append('--delete-local-data')
296+
# The '--delete-local-data' flag is being deprecated.
297+
# A new flag was introduced in OpenShift 4.7 ('--delete-emptydir-data').
298+
# The following logic is to provide backward compatibility for folks that
299+
# may not update their 'oc' binaries all that often.
300+
version = get_client_version()
301+
pieces = version.split('.')
302+
major = int(pieces[0])
303+
minor = int(pieces[1])
304+
305+
# Local builds of OC have `alpha` in their version string. We are going
306+
# to assume that anyone building their own version of 'oc' will most
307+
# likely have the latest/greatest code that contains the new flag.
308+
if 'alpha' in version or major > 4 or (major == 4 and minor >= 7):
309+
base_args.append('--delete-emptydir-data')
310+
else:
311+
base_args.append('--delete-local-data')
297312

298313
if force:
299314
base_args.append('--force')

0 commit comments

Comments
 (0)