From c15bf4810228dff55e1ec8222f793ee8bd126e4c Mon Sep 17 00:00:00 2001 From: smg247 Date: Fri, 10 Jul 2026 08:27:20 -0600 Subject: [PATCH] sippy: rename verify-migrations presubmit to verify Repurpose the verify-migrations job to run the broader `make verify` target and always run on PRs instead of only on migration changes. Co-Authored-By: Claude Opus 4.6 --- .../openshift/sippy/openshift-sippy-main.yaml | 5 ++--- .../sippy/openshift-sippy-main-presubmits.yaml | 13 ++++++------- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/ci-operator/config/openshift/sippy/openshift-sippy-main.yaml b/ci-operator/config/openshift/sippy/openshift-sippy-main.yaml index 7b78ea03714b8..45cb406b08e6b 100644 --- a/ci-operator/config/openshift/sippy/openshift-sippy-main.yaml +++ b/ci-operator/config/openshift/sippy/openshift-sippy-main.yaml @@ -47,11 +47,10 @@ tests: commands: HOME=/tmp make lint container: from: src -- as: verify-migrations - commands: HOME=/tmp make verify-migrations +- as: verify + commands: HOME=/tmp make verify container: from: src - run_if_changed: ^pkg/db/migrations/ - as: yaml-lint commands: IS_CONTAINER=TRUE ./hack/yaml-lint.sh container: diff --git a/ci-operator/jobs/openshift/sippy/openshift-sippy-main-presubmits.yaml b/ci-operator/jobs/openshift/sippy/openshift-sippy-main-presubmits.yaml index 3b1f88081dcda..b80e71efc8ba4 100644 --- a/ci-operator/jobs/openshift/sippy/openshift-sippy-main-presubmits.yaml +++ b/ci-operator/jobs/openshift/sippy/openshift-sippy-main-presubmits.yaml @@ -559,12 +559,12 @@ presubmits: secretName: result-aggregator trigger: (?m)^/test( | .* )unit,?($|\s.*) - agent: kubernetes - always_run: false + always_run: true branches: - ^main$ - ^main- cluster: build13 - context: ci/prow/verify-migrations + context: ci/prow/verify decorate: true decoration_config: sparse_checkout_files: @@ -574,16 +574,15 @@ presubmits: labels: ci.openshift.io/generator: prowgen pj-rehearse.openshift.io/can-be-rehearsed: "true" - name: pull-ci-openshift-sippy-main-verify-migrations - rerun_command: /test verify-migrations - run_if_changed: ^pkg/db/migrations/ + name: pull-ci-openshift-sippy-main-verify + rerun_command: /test verify spec: containers: - args: - --gcs-upload-secret=/secrets/gcs/service-account.json - --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson - --report-credentials-file=/etc/report/credentials - - --target=verify-migrations + - --target=verify command: - ci-operator env: @@ -624,7 +623,7 @@ presubmits: - name: result-aggregator secret: secretName: result-aggregator - trigger: (?m)^/test( | .* )verify-migrations,?($|\s.*) + trigger: (?m)^/test( | .* )verify,?($|\s.*) - agent: kubernetes always_run: false branches: