Skip to content

[DZ-Storage] Adding cinderBackups to controlplane#760

Draft
gais-ameer-rh wants to merge 1 commit into
openstack-k8s-operators:mainfrom
gais-ameer-rh:OSPRH-28342
Draft

[DZ-Storage] Adding cinderBackups to controlplane#760
gais-ameer-rh wants to merge 1 commit into
openstack-k8s-operators:mainfrom
gais-ameer-rh:OSPRH-28342

Conversation

@gais-ameer-rh
Copy link
Copy Markdown

@gais-ameer-rh gais-ameer-rh commented May 15, 2026

To deploy multiple cinder backups based on AZ topology

Removes the existing spec.cinder.template.cinderBackup (singluar)
and replaces with cinderBackups (plural)

Jira: OSPRH-28342
Signed-off-by: Gais Ameer gameer@redhat.com

Depends-On: openstack-k8s-operators/ci-framework#3927

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 15, 2026

Hi @gais-ameer-rh. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fultonj fultonj self-requested a review May 15, 2026 13:46
Copy link
Copy Markdown
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gais.

Overall looks good. There's a few small changes I would like.

There are two duplicate commits (b5f6ccc and 2436c3a) with very similar messages. Please use git squash so turn them into one commit.

https://github.com/openstack-k8s-operators/architecture/pull/760/commits

Thanks

Comment thread examples/dt/dz-storage/control-plane/service-values.yaml Outdated
Comment thread examples/dt/dz-storage/validate.md Outdated
Comment thread examples/dt/dz-storage/validate.md
@fultonj
Copy link
Copy Markdown
Contributor

fultonj commented May 15, 2026

The expected change in the oscp is produced.

$ diff -u /tmp/cr-review/before.yaml /tmp/cr-review/after.yaml                                                                                                                                        
--- /tmp/cr-review/before.yaml  2026-05-15 14:54:48.290074926 -0400                                                                                                                                                                                            
+++ /tmp/cr-review/after.yaml   2026-05-15 14:54:57.735261671 -0400
@@ -204,14 +204,52 @@
                 type: LoadBalancer
         replicas: 3
       cinderBackup:
-        customServiceConfig: |
-          [DEFAULT]
-          # Not implemented in this example
         networkAttachments:
         - storage
         replicas: 0
-        topologyRef:
-          name: azone-node-affinity
+      cinderBackups:
+        cinder-backup-az0:
+          customServiceConfig: |
+            [DEFAULT]
+            backup_share = _replaced_
+            backup_driver = cinder.backup.drivers.nfs.NFSBackupDriver
+            backup_mount_point_base = /var/lib/cinder/backup
+            storage_availability_zone = az0
+          customServiceConfigSecrets:
+          - cinder-volume-secrets-az0
+          networkAttachments:
+          - storage
+          replicas: 2
+          topologyRef:
+            name: azone-node-affinity
+        cinder-backup-az1:
+          customServiceConfig: |
+            [DEFAULT]
+            backup_share = _replaced_
+            backup_driver = cinder.backup.drivers.nfs.NFSBackupDriver
+            backup_mount_point_base = /var/lib/cinder/backup
+            storage_availability_zone = az1
+          customServiceConfigSecrets:
+          - cinder-volume-secrets-az1
+          networkAttachments:
+          - storage
+          replicas: 2
+          topologyRef:
+            name: bzone-node-affinity
+        cinder-backup-az2:
+          customServiceConfig: |
+            [DEFAULT]
+            backup_share = _replaced_
+            backup_driver = cinder.backup.drivers.nfs.NFSBackupDriver
+            backup_mount_point_base = /var/lib/cinder/backup
+            storage_availability_zone = az2
+          customServiceConfigSecrets:
+          - cinder-volume-secrets-az2
+          networkAttachments:
+          - storage
+          replicas: 2
+          topologyRef:
+            name: czone-node-affinity
       cinderScheduler:
         replicas: 1
       cinderVolumes:
$ 

Comment thread examples/dt/dz-storage/control-plane/service-values.yaml Outdated
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gais-ameer-rh
Once this PR has been reviewed and has the lgtm label, please ask for approval from fultonj. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

To deploy multiple cinder backups based on AZ topology

Removes the existing spec.cinder.template.cinderBackup (singluar)
and replaces with cinderBackups (plural)

Jira: OSPRH-28342

Signed-off-by: Gais Ameer <gameer@redhat.com>
@fultonj fultonj dismissed their stale review May 19, 2026 13:46

requested change was made

@fultonj
Copy link
Copy Markdown
Contributor

fultonj commented May 19, 2026

Overall this /lgtm Let's confirm we get a green test project before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants