stlouis milan_dxio_init fix invalid success return#4
Draft
pldubouilh wants to merge 1 commit into
Draft
Conversation
|
Thanks! It's true that we don't use the github PR flow for our development process, but I'll create an issue in our tracker for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think there might be a silenced error on the
milan_dxio_initfunction, on the path initingPHY_PROGandSKIP_PSP.This came out as I was reviewing the Milan path, and I don't have hardware to test on ! In any case if it's intended to ignore errors here, I think a comment would be good.
You don't seem to be taking PRs here, but I just wanted to surface this. Cheers !