style: lint

Author: bennypowers

core/pfe-core/controllers/internals-controller.ts

@@ -340,7 +340,7 @@ export class InternalsController implements ReactiveController, ARIAMixin {
 /** @see https://w3c.github.io/aria/#ref-for-dom-ariamixin-ariaactivedescendantelement-1 */
 declare global {
   // https://github.com/webcomponents-cg/community-protocols/pull/75
-  var _elementInternals: WeakMap<Element, ElementInternals>; // eslint-disable-line no-var
+  var _elementInternals: WeakMap<Element, ElementInternals>;
   interface ARIAMixin {
     ariaActiveDescendantElement: Element | null;
     ariaControlsElements: readonly Element[] | null;

core/pfe-core/controllers/slot-controller-server.ts

@@ -12,7 +12,7 @@ export class SlotController implements SlotControllerPublicAPI {
 
   static anonymousAttribute = 'ssr-hint-has-slotted-default' as const;
 
-  constructor(public host: ReactiveElement, ..._: SlotControllerArgs) {
+  constructor(public host: ReactiveElement, ..._args: SlotControllerArgs) {
     host.addController(this);
   }
 
@@ -24,7 +24,7 @@ export class SlotController implements SlotControllerPublicAPI {
         .map(x => x.trim());
   }
 
-  getSlotted<T extends Element = Element>(..._: (string | null)[]): T[] {
+  getSlotted<T extends Element = Element>(..._names: (string | null)[]): T[] {
     return [];
   }
 

core/pfe-core/controllers/test/combobox-controller.spec.ts

@@ -1,4 +1,4 @@
-import { expect, fixture, nextFrame } from '@open-wc/testing';
+import { expect, fixture } from '@open-wc/testing';
 import { sendKeys } from '@web/test-runner-commands';
 import { a11ySnapshot } from '@patternfly/pfe-tools/test/a11y-snapshot.js';
 

elements/pf-v5-alert/pf-v5-alert.ts

@@ -1,7 +1,6 @@
 import { LitElement, html, type TemplateResult } from 'lit';
 import { customElement } from 'lit/decorators/custom-element.js';
 import { property } from 'lit/decorators/property.js';
-import { classMap } from 'lit/directives/class-map.js';
 import { ifDefined } from 'lit/directives/if-defined.js';
 
 import { observes } from '@patternfly/pfe-core/decorators.js';

elements/pf-v5-hint/test/pf-hint.spec.ts

@@ -22,9 +22,8 @@ describe('<pf-v5-hint>', function() {
   });
 
   describe('basic hint', function() {
-    let element: PfV5Hint;
     beforeEach(async function() {
-      element = await createFixture<PfV5Hint>(html`
+      await createFixture<PfV5Hint>(html`
         <pf-v5-hint>Welcome to the new documentation experience.</pf-v5-hint>
       `);
     });

elements/pf-v5-search-input/demo/index.html

@@ -29,9 +29,7 @@
   const searchInput = document.getElementById('search-input');
 
   searchInput.addEventListener('change', (event) => {
-    /* eslint-disable no-console */
     console.log('Selected:', event.target.value);
-    /* eslint-disable no-console */
   });
 </script>
 

elements/pf-v5-search-input/demo/pf-search-input-with-submit.html

@@ -33,17 +33,13 @@
   const searchInput = document.getElementById('search-input');
 
   searchInput.addEventListener('change', (event) => {
-    /* eslint-disable no-console */
     console.log('Selected:', event.target.value);
-    /* eslint-disable no-console */
   });
 
   const form = document.querySelector('form.container');
   form.addEventListener('submit', (event) =>{
     event.preventDefault();
-    /* eslint-disable no-console */
     console.log("Value:", form.elements.search?.value);
-    /* eslint-disable no-console */
   })
 </script>
 

tools/pfe-tools/package.json

@@ -78,10 +78,9 @@
     "@web/dev-server-import-maps": "^0.2.1",
     "@web/dev-server-rollup": "^0.6.4",
     "@web/test-runner": "^0.20.2",
+    "@web/test-runner-chrome": "^0.18.0",
     "@web/test-runner-commands": "^0.9.0",
     "@web/test-runner-junit-reporter": "^0.8.0",
-    "@web/test-runner-chrome": "^0.18.0",
-    "puppeteer": "^24.0.0",
     "chalk": "^5.6.2",
     "clean-css": "^5.3.3",
     "colorjs.io": "^0.6.0",
@@ -103,6 +102,7 @@
     "nunjucks": "^3.2.4",
     "patch-package": "^8.0.1",
     "playwright": "~1.57.0",
+    "puppeteer": "^24.0.0",
     "rollup-plugin-lit-css": "^6.0.0",
     "sinon": "^21.0.1",
     "ts-lit-plugin": "^2.0.2",

tools/pfe-tools/test/create-fixture.ts

@@ -1,6 +1,6 @@
 import type { TemplateResult } from 'lit';
 import { chai, fixtureCleanup, fixture } from '@open-wc/testing';
-// @ts-ignore: colorjs.io types not resolved with Node moduleResolution on Windows CI
+// @ts-expect-error: colorjs.io types not resolved with Node moduleResolution on Windows CI
 import Color from 'colorjs.io';
 
 /**

web-dev-server.config.js

@@ -1,7 +1,4 @@
-import {
-  pfeDevServerConfig,
-  getPatternflyIconNodemodulesImports,
-} from '@patternfly/pfe-tools/dev-server/config.js';
+import { pfeDevServerConfig } from '@patternfly/pfe-tools/dev-server/config.js';
 import { makeDemoEnv } from '@patternfly/pfe-tools/environment.js';
 
 import { writeFile, mkdir } from 'node:fs/promises';