Skip to content

Commit 68e925a

Browse files
committed
test(avatar): improve tests
1 parent f257006 commit 68e925a

1 file changed

Lines changed: 10 additions & 22 deletions

File tree

elements/pf-v6-avatar/test/pf-v6-avatar.spec.ts

Lines changed: 10 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -43,24 +43,24 @@ describe('<pf-v6-avatar>', function() {
4343

4444
describe('with a src attr', function() {
4545
let element: PfV6Avatar;
46-
let loaded: string | undefined;
46+
let loadEvent: Event | undefined;
4747
const datauri = 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAIAAAACACAYAAADDPmHLAAAB0UlEQVR4Xu3UAQ0AAAyDsM+/6QspcwAh2zXawGj64K8A8AgKoABwAzh+D1AAuAEcvwcoANwAjt8DFABuAMfvAQoAN4Dj9wAFgBvA8XuAAsAN4Pg9QAHgBnD8HqAAcAM4fg9QALgBHL8HKADcAI7fAxQAbgDH7wEKADeA4/cABYAbwPF7gALADeD4PUAB4AZw/B6gAHADOH4PUAC4ARy/BygA3ACO3wMUAG4Ax+8BCgA3gOP3AAWAG8Dxe4ACwA3g+D1AAeAGcPweoABwAzh+D1AAuAEcvwcoANwAjt8DFABuAMfvAQoAN4Dj9wAFgBvA8XuAAsAN4Pg9QAHgBnD8HqAAcAM4fg9QALgBHL8HKADcAI7fAxQAbgDH7wEKADeA4/cABYAbwPF7gALADeD4PUAB4AZw/B6gAHADOH4PUAC4ARy/BygA3ACO3wMUAG4Ax+8BCgA3gOP3AAWAG8Dxe4ACwA3g+D1AAeAGcPweoABwAzh+D1AAuAEcvwcoANwAjt8DFABuAMfvAQoAN4Dj9wAFgBvA8XuAAsAN4Pg9QAHgBnD8HqAAcAM4fg9QALgBHL8HKADcAI7fAxQAbgDH7wEKADeA4/cABYAbwPF7ADyAB6SPAIFm19U7AAAAAElFTkSuQmCC';
48-
const onLoad = (e: PfV6AvatarLoadEvent) => {
49-
const paths = e.originalEvent.composedPath() as HTMLImageElement[];
50-
loaded = paths.find(x => x.localName === 'img')?.src;
51-
};
5248
beforeEach(async function() {
53-
element = await createFixture(html`<pf-v6-avatar @load="${onLoad}"></pf-v6-avatar>`);
49+
element = await createFixture(html`<pf-v6-avatar></pf-v6-avatar>`);
50+
element.addEventListener('load', function(e) {
51+
loadEvent = e;
52+
});
5453
setTimeout(() => element.src = datauri);
5554
await oneEvent(element, 'load');
5655
});
5756

58-
it('loads the image', function() {
59-
expect(loaded).to.equal(datauri);
57+
it('should fire a PfV6AvatarLoadEvent', function() {
58+
expect(loadEvent).to.be.an.instanceOf(PfV6AvatarLoadEvent);
6059
});
6160

62-
it('fires a PfV6AvatarLoadEvent', function() {
63-
expect(loaded).to.be.ok;
61+
it('should include the original event', function() {
62+
expect(loadEvent).to.have.property('originalEvent')
63+
.that.is.an.instanceOf(Event);
6464
});
6565
});
6666

@@ -133,16 +133,4 @@ describe('<pf-v6-avatar>', function() {
133133
expect(element.offsetHeight).to.equal(128);
134134
});
135135
});
136-
137-
describe('with bordered', function() {
138-
let element: PfV6Avatar;
139-
beforeEach(async function() {
140-
element = await createFixture(html`<pf-v6-avatar bordered></pf-v6-avatar>`);
141-
await nextFrame();
142-
});
143-
144-
it('renders with a visible border', function() {
145-
expect(element.offsetWidth).to.be.greaterThan(36);
146-
});
147-
});
148136
});

0 commit comments

Comments
 (0)