Skip to content

Commit e90ca21

Browse files
authored
Merge branch 'main' into fix/slot-controller-get-slotted
2 parents 5e2f20b + cc84a12 commit e90ca21

13 files changed

Lines changed: 49 additions & 7 deletions
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@patternfly/elements": patch
3+
---
4+
5+
`<pf-back-to-top>`: fixed background color during hover and focus.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
"@patternfly/create-element": patch
3+
---
4+
Fixed missing files in published package that prevented `npm run new` from working

.changeset/fix-create-element.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@patternfly/create-element": patch
3+
---
4+
5+
Fixed missing entry point in published package.
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@patternfly/elements": patch
3+
---
4+
5+
`npm run start` no longer fails when TypeScript build artifacts
6+
are present in the working tree.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
"@patternfly/elements": patch
3+
---
4+
`<pf-table>`: fix accessibility features: column header role, accessible label for row toggle button, etc.

elements/pf-back-to-top/pf-back-to-top.css

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,16 @@ a {
4141
gap: var(--pf-c-button__icon--m-end--MarginLeft, var(--pf-global--spacer--xs, 0.25rem));
4242
}
4343

44-
a:hover {
44+
a:hover,
45+
a:focus {
4546
--pf-c-button--m-primary--Color: var(--pf-c-button--m-primary--hover--Color, var(--pf-global--Color--light-100, #fff));
4647
--pf-c-button--m-primary--BackgroundColor: var(--pf-c-button--m-primary--hover--BackgroundColor, var(--pf-global--primary-color--200, #004080));
4748
}
4849

49-
a:focus {
50-
--pf-c-button--m-primary--Color: var(--pf-c-button--m-primary--hover--Color, var(--pf-global--Color--light-100,#fff));
50+
[part="trigger"]:is(pf-button):hover,
51+
[part="trigger"]:is(pf-button):focus-within {
5152
--pf-c-button--m-primary--BackgroundColor: var(--pf-c-button--m-primary--hover--BackgroundColor, var(--pf-global--primary-color--200, #004080));
53+
--pf-c-button--m-primary--Color: var(--pf-c-button--m-primary--hover--Color, var(--pf-global--Color--light-100, #fff));
5254
}
5355

5456
[part="trigger"][hidden] {

elements/pf-table/context.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ import { createContextWithRoot } from '@patternfly/pfe-core/functions/context.js
22

33
export const thRoleContext: {
44
__context__: unknown;
5-
} = createContextWithRoot<'rowheader' | 'colheader'>('pf-th-role');
5+
} = createContextWithRoot<'rowheader' | 'columnheader'>('pf-th-role');

elements/pf-table/pf-th.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export class PfTh extends LitElement {
5151
@property() key!: string;
5252

5353
@consume({ context: thRoleContext })
54-
private contextualRole: 'colheader' | 'rowheader' = 'rowheader';
54+
private contextualRole: 'columnheader' | 'rowheader' = 'rowheader';
5555

5656
override connectedCallback(): void {
5757
super.connectedCallback();

elements/pf-table/pf-thead.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import { provide } from '@lit/context';
1414
export class PfThead extends LitElement {
1515
static readonly styles: CSSStyleSheet[] = [styles];
1616

17-
@provide({ context: thRoleContext }) private thRowContext = 'colheader';
17+
@provide({ context: thRoleContext }) private thRowContext = 'columnheader';
1818

1919
connectedCallback(): void {
2020
super.connectedCallback();

elements/pf-table/pf-tr.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,9 @@ export class PfTr extends LitElement {
109109
<pf-td id="toggle-cell">
110110
<pf-button id="toggle-button"
111111
aria-expanded=${String(this.expanded) as 'true' | 'false'}
112+
aria-controls=${ifDefined(this.expanded ? 'expansion' : undefined)}
112113
plain
114+
label="Details"
113115
@click=${this.#onClick}>
114116
<pf-icon id="toggle-icon"
115117
icon="angle-right"

0 commit comments

Comments
 (0)