fix(core): clear #nextIntersection safeguard timeout on exit

bennypowers · bennypowers · commit fa1ed380b14b · 2026-03-09T01:43:20.000+02:00
Prevents a stale 3s timeout from prematurely resolving a subsequent
#nextIntersection() call.

Assisted-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/core/pfe-core/controllers/scroll-spy-controller.ts b/core/pfe-core/controllers/scroll-spy-controller.ts
@@ -213,10 +213,11 @@ export class ScrollSpyController implements ReactiveController {
   async #nextIntersection() {
     this.#intersected = false;
     // safeguard: break the loop after 3s even if no intersection fires
-    setTimeout(() => this.#intersected = true, 3000);
+    const timer = setTimeout(() => this.#intersected = true, 3000);
     while (!this.#intersected) {
       await new Promise(requestAnimationFrame);
     }
+    clearTimeout(timer);
   }
 
   async #onIo(entries: IntersectionObserverEntry[]) {

Original file line number	Diff line number	Diff line change
`@@ -213,10 +213,11 @@ export class ScrollSpyController implements ReactiveController {`
`213`	`213`	`async #nextIntersection() {`
`214`	`214`	`this.#intersected = false;`
`215`	`215`	`// safeguard: break the loop after 3s even if no intersection fires`
`216`		`- setTimeout(() => this.#intersected = true, 3000);`
	`216`	`+ const timer = setTimeout(() => this.#intersected = true, 3000);`
`217`	`217`	`while (!this.#intersected) {`
`218`	`218`	`await new Promise(requestAnimationFrame);`
`219`	`219`	`}`
	`220`	`+ clearTimeout(timer);`
`220`	`221`	`}`
`221`	`222`
`222`	`223`	`async #onIo(entries: IntersectionObserverEntry[]) {`