Updated scroll logic, removed plain

Author: thatblindgeye

packages/react-core/src/components/Pagination/Pagination.tsx

@@ -123,13 +123,9 @@ export interface PaginationProps extends React.HTMLProps<HTMLDivElement>, OUIAPr
   isDisabled?: boolean;
   /** Flag indicating if pagination is compact. */
   isCompact?: boolean;
-  /** @beta Adds plain styling to the pagination. */
-  isPlain?: boolean;
-  /** @beta Prevents the pagination from automatically applying plain styling when glass theme is enabled. */
-  isNoPlainOnGlass?: boolean;
   /** Flag indicating if pagination should not be sticky on mobile. */
   isStatic?: boolean;
-  /** Flag indicating if pagination should stick to its position (based on variant). For dynamic sticky contro, use isStickyBase
+  /** Flag indicating if pagination should stick to its position (based on variant). For dynamic sticky control, use isStickyBase
    * and isStickyStuck instead.
    */
   isSticky?: boolean;
@@ -201,8 +197,6 @@ export const Pagination: React.FunctionComponent<PaginationProps> = ({
   variant = PaginationVariant.top,
   isDisabled = false,
   isCompact = false,
-  isPlain = false,
-  isNoPlainOnGlass = false,
   isStatic = false,
   isSticky = false,
   isStickyBase = false,
@@ -307,8 +301,6 @@ export const Pagination: React.FunctionComponent<PaginationProps> = ({
         isSticky && !isStickyBase && !isStickyStuck && styles.modifiers.sticky,
         isStickyBase && styles.modifiers.stickyBase,
         isStickyStuck && styles.modifiers.stickyStuck,
-        isPlain && styles.modifiers.plain,
-        isNoPlainOnGlass && styles.modifiers.noPlainOnGlass,
         className
       )}
       {...(widgetId && { id: `${widgetId}-${variant}-pagination` })}

packages/react-core/src/components/Pagination/__tests__/Pagination.test.tsx

@@ -119,28 +119,6 @@ describe('Pagination', () => {
       expect(screen.getByTestId('pagination-insets')).toHaveClass('pf-m-page-insets');
     });
 
-    test(`should not render ${styles.modifiers.plain} class by default`, () => {
-      render(<Pagination data-testid="pagination-plain-default" itemCount={20} />);
-      expect(screen.getByTestId('pagination-plain-default')).not.toHaveClass(styles.modifiers.plain);
-    });
-
-    test(`should render ${styles.modifiers.plain} class when isPlain is true`, () => {
-      render(<Pagination data-testid="pagination-plain" itemCount={20} isPlain />);
-      expect(screen.getByTestId('pagination-plain')).toHaveClass(styles.modifiers.plain);
-    });
-
-    test(`should not render ${styles.modifiers.noPlainOnGlass} class by default`, () => {
-      render(<Pagination data-testid="pagination-no-plain-on-glass-default" itemCount={20} />);
-      expect(screen.getByTestId('pagination-no-plain-on-glass-default')).not.toHaveClass(
-        styles.modifiers.noPlainOnGlass
-      );
-    });
-
-    test(`should render ${styles.modifiers.noPlainOnGlass} class when isNoPlainOnGlass is true`, () => {
-      render(<Pagination data-testid="pagination-no-plain-on-glass" itemCount={20} isNoPlainOnGlass />);
-      expect(screen.getByTestId('pagination-no-plain-on-glass')).toHaveClass(styles.modifiers.noPlainOnGlass);
-    });
-
     test(`should not render ${styles.modifiers.stickyBase} class by default`, () => {
       render(<Pagination data-testid="pagination-sticky-base-default" itemCount={20} />);
       expect(screen.getByTestId('pagination-sticky-base-default')).not.toHaveClass(styles.modifiers.stickyBase);