From 122aebb485483b5f0f401ca7f1210a4708b476e6 Mon Sep 17 00:00:00 2001 From: NULL Date: Thu, 9 Jul 2026 13:43:52 -0400 Subject: [PATCH] feat(MenuToggle): add aria-haspopup prop Adds the aria-haspopup prop to MenuToggle with a default value of 'menu'. Updates all Select implementations across examples and demos to explicitly pass aria-haspopup="listbox" to properly reflect their semantic role, addressing issue #11792 (PF-1704). --- .../src/components/Form/examples/FormState.tsx | 2 +- .../LoginPage/examples/LoginPageLanguageSelect.tsx | 2 +- .../react-core/src/components/MenuToggle/MenuToggle.tsx | 9 ++++++++- .../__tests__/__snapshots__/MenuToggle.test.tsx.snap | 9 +++++++++ .../src/components/Select/examples/SelectBasic.tsx | 2 +- .../src/components/Select/examples/SelectCheckbox.tsx | 2 +- .../src/components/Select/examples/SelectFooter.tsx | 2 +- .../src/components/Select/examples/SelectGrouped.tsx | 2 +- .../components/Select/examples/SelectMultiTypeahead.tsx | 2 +- .../Select/examples/SelectMultiTypeaheadCheckbox.tsx | 2 +- .../Select/examples/SelectMultiTypeaheadCreatable.tsx | 2 +- .../Select/examples/SelectOptionVariations.tsx | 2 +- .../src/components/Select/examples/SelectTypeahead.tsx | 2 +- .../Select/examples/SelectTypeaheadCreatable.tsx | 2 +- .../src/components/Select/examples/SelectValidated.tsx | 2 +- .../src/components/Select/examples/SelectViewMore.tsx | 2 +- .../examples/ToolbarComponentManagedToggleGroups.tsx | 4 ++-- .../examples/ToolbarConsumerManagedToggleGroups.tsx | 4 ++-- .../Toolbar/examples/ToolbarCustomLabelGroupContent.tsx | 4 ++-- .../src/components/Toolbar/examples/ToolbarGroups.tsx | 6 +++--- .../src/components/Toolbar/examples/ToolbarStacked.tsx | 4 ++-- .../components/Toolbar/examples/ToolbarWithFilters.tsx | 4 ++-- .../src/components/Tooltip/examples/TooltipOptions.tsx | 4 ++-- 23 files changed, 46 insertions(+), 30 deletions(-) diff --git a/packages/react-core/src/components/Form/examples/FormState.tsx b/packages/react-core/src/components/Form/examples/FormState.tsx index 2431e47990d..1b5ab4be089 100644 --- a/packages/react-core/src/components/Form/examples/FormState.tsx +++ b/packages/react-core/src/components/Form/examples/FormState.tsx @@ -62,7 +62,7 @@ export const FormState = () => { selected={getValue('select-id')} isOpen={isSelectOpen} toggle={(toggleRef) => ( - setIsSelectOpen(isOpen)} isExpanded={isSelectOpen} diff --git a/packages/react-core/src/components/LoginPage/examples/LoginPageLanguageSelect.tsx b/packages/react-core/src/components/LoginPage/examples/LoginPageLanguageSelect.tsx index 12abe7a9448..b32dc7b343b 100644 --- a/packages/react-core/src/components/LoginPage/examples/LoginPageLanguageSelect.tsx +++ b/packages/react-core/src/components/LoginPage/examples/LoginPageLanguageSelect.tsx @@ -81,7 +81,7 @@ export const LoginPageLanguageSelect: React.FunctionComponent = () => { ) => ( - onStatusToggle()} isExpanded={statusIsExpanded} @@ -92,7 +92,7 @@ export const ToolbarComponentManagedToggleGroup: React.FunctionComponent = () => ) => ( - onStatusToggle()} isExpanded={statusIsExpanded} @@ -97,7 +97,7 @@ export const ToolbarConsumerManagedToggleGroup: React.FunctionComponent = () => ) => ( - onToggle('first')} isExpanded={firstIsExpanded} @@ -91,7 +91,7 @@ export const ToolbarGroups: React.FunctionComponent = () => { ) => ( - onToggle('third')} isExpanded={thirdIsExpanded} diff --git a/packages/react-core/src/components/Toolbar/examples/ToolbarStacked.tsx b/packages/react-core/src/components/Toolbar/examples/ToolbarStacked.tsx index 1d917f43baf..6a770a039fe 100644 --- a/packages/react-core/src/components/Toolbar/examples/ToolbarStacked.tsx +++ b/packages/react-core/src/components/Toolbar/examples/ToolbarStacked.tsx @@ -135,7 +135,7 @@ export const ToolbarStacked: React.FunctionComponent = () => { ) => ( - onStatusToggle()} isExpanded={statusIsExpanded} diff --git a/packages/react-core/src/components/Toolbar/examples/ToolbarWithFilters.tsx b/packages/react-core/src/components/Toolbar/examples/ToolbarWithFilters.tsx index 1bf48886d70..b98acdf2001 100644 --- a/packages/react-core/src/components/Toolbar/examples/ToolbarWithFilters.tsx +++ b/packages/react-core/src/components/Toolbar/examples/ToolbarWithFilters.tsx @@ -146,7 +146,7 @@ export const ToolbarWithFilters: React.FunctionComponent = () => { aria-label="Status" role="menu" toggle={(toggleRef: React.Ref) => ( - { aria-label="Risk" role="menu" toggle={(toggleRef: React.Ref) => ( - { position (will flip if enableFlip is true). The 'auto' position requires enableFlip to be set to true.