Open queries autoruns when I start the app

[jonashilmersson]

Please note that security bugs or issues should be reported to security@pgadmin.org.

Describe the bug

When I have opened queries from the last session, they automatically gets executed on the next startup of the app.

To Reproduce

Steps to reproduce the behavior:

1. Start the app and connect to a server.
2. Open a query window and write a SELECT that gets data from an existing table.
3. Close the app with the query window open.
4. Restart the app.
5. The previous query window is opened again and executed.

Expected behavior

The query should not be automatically executed. Imagine if I have a DELETE query saved and that runs.

Error message

If possible, include the full, unedited text of any error messages displayed.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Windows-11-10.0.26200-SP0
• pgAdmin version: 9.15
• Mode: Desktop
• Package type: [e.g. RPM, DEB, Python, Container, etc.]

Additional context

Add any other context about the problem here.

[dev-hari-prasad]

Thanks for reporting this.

I was able to reproduce it locally following the steps. After looking through the restore process, it looks like restored Query Tool tabs can end up being identified incorrectly during initialization.

Because of that, they may go through logic that is intended for the view or edit data tabs, which can result in the query being executed automatically when pgAdmin starts. I have put together a fix and opened a PR for review. Expect this to be fixed soon.

[jonashilmersson]

Wow, that was fast, good job!