Unnecessary reconnection due to visibilitychange

[avs-doom]

Hi!

"phoenix": "1.8.3"

I noticed that after I disconnected the connection via socket.disconnect, left the tab and returned, phoenix returned the socket connection back, this is extremely strange behavior that I did not expect. Is there any way to prohibit reconnection using this case? Judging by the code, phoenix is constantly reconnecting, regardless of whether it was forcibly terminated or whether the connection was lost for other reasons

phxWindow.addEventListener("visibilitychange", () => {
        if (document.visibilityState === "hidden") {
          this.pageHidden = true;
        } else {
          this.pageHidden = false;
          if (!this.isConnected()) {
            this.teardown(() => this.connect());
          }
        }
      });

[stjhimy]

The visibilitychange handler reconnects unconditionally because we want users who lost connection while the tab was hidden to seamlessly reconnect when they return?

[SteffenDE]

We should check if the socket was disconnected deliberately and then skip the reconnect. If you're interested in contributing, a PR is welcome!

[avs-doom]

#6579

[SteffenDE]

Closed via #6579.