Fixing memory leaks

JarneClauw · JarneClauw · commit 79778e2712f2 · 2026-05-06T19:00:23.000+02:00
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -4261,6 +4261,7 @@ PHP_FUNCTION(openssl_seal)
 
 	iv_len = EVP_CIPHER_iv_length(cipher);
 	if (!iv && iv_len > 0) {
+		php_openssl_release_evp_cipher(cipher);
 		zend_argument_value_error(6, "cannot be null for the chosen cipher algorithm");
 		RETURN_THROWS();
 	}
@@ -4347,6 +4348,7 @@ PHP_FUNCTION(openssl_seal)
 	efree(eks);
 	efree(eksl);
 	efree(pkeys);
+	php_openssl_release_evp_cipher(cipher);
 }
 /* }}} */
 
@@ -4423,6 +4425,7 @@ PHP_FUNCTION(openssl_open)
 	EVP_CIPHER_CTX_free(ctx);
 out_pkey:
 	EVP_PKEY_free(pkey);
+	php_openssl_release_evp_cipher(cipher);
 }
 /* }}} */
 

Original file line number	Diff line number	Diff line change
`@@ -4261,6 +4261,7 @@ PHP_FUNCTION(openssl_seal)`
`4261`	`4261`
`4262`	`4262`	`iv_len = EVP_CIPHER_iv_length(cipher);`
`4263`	`4263`	`if (!iv && iv_len > 0) {`
	`4264`	`+ php_openssl_release_evp_cipher(cipher);`
`4264`	`4265`	`zend_argument_value_error(6, "cannot be null for the chosen cipher algorithm");`
`4265`	`4266`	`RETURN_THROWS();`
`4266`	`4267`	`}`
`@@ -4347,6 +4348,7 @@ PHP_FUNCTION(openssl_seal)`
`4347`	`4348`	`efree(eks);`
`4348`	`4349`	`efree(eksl);`
`4349`	`4350`	`efree(pkeys);`
	`4351`	`+ php_openssl_release_evp_cipher(cipher);`
`4350`	`4352`	`}`
`4351`	`4353`	`/* }}} */`
`4352`	`4354`
`@@ -4423,6 +4425,7 @@ PHP_FUNCTION(openssl_open)`
`4423`	`4425`	`EVP_CIPHER_CTX_free(ctx);`
`4424`	`4426`	`out_pkey:`
`4425`	`4427`	`EVP_PKEY_free(pkey);`
	`4428`	`+ php_openssl_release_evp_cipher(cipher);`
`4426`	`4429`	`}`
`4427`	`4430`	`/* }}} */`
`4428`	`4431`