After review 1

Author: tatevikg1

src/Controller/SubscribersController.php

@@ -9,10 +9,12 @@
 use PhpList\RestApiClient\Entity\Subscriber;
 use PhpList\RestApiClient\Request\Subscriber\ExportSubscriberRequest;
 use PhpList\RestApiClient\Request\Subscriber\SubscribersFilterRequest;
+use PhpList\RestApiClient\Response\Subscribers\SubscriberCollection;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpFoundation\StreamedResponse;
 use Symfony\Component\Routing\Attribute\Route;
 
 #[Route('/subscribers', name: 'subscriber_')]
@@ -66,55 +68,26 @@ public function index(Request $request): JsonResponse|Response
             $prevId = $history[$index - 1];
         }
 
-        $initialData = [
-            'items' => array_map(static function (Subscriber $subscriber) {
-                return [
-                    'id' => $subscriber->id,
-                    'email' => $subscriber->email,
-                    'confirmed' => $subscriber->confirmed,
-                    'blacklisted' => $subscriber->blacklisted,
-                    'createdAt' => (new DateTimeImmutable($subscriber->createdAt))->format('Y-m-d H:i:s'),
-                    'uniqueId' => $subscriber->uniqueId,
-                    'listCount' => count($subscriber->subscribedLists),
-                ];
-            }, $collection->items ?? []),
-            'pagination' => [
-                'limit' => $collection->pagination->limit,
-                'afterId' => $collection->pagination->nextCursor,
-                'hasMore' => $collection->pagination->hasMore ,
-                'total' => $collection->pagination->total,
-                'prevId' => $prevId,
-                'isFirstPage' => $afterId === null,
-            ],
-        ];
-
-        return $this->json($initialData);
+        return $this->json($this->normalize($collection, $prevId, $afterId));
     }
 
+    /**
+     * @SuppressWarnings("CyclomaticComplexity")
+     * @SuppressWarnings("NPathComplexity")
+     */
     #[Route('/export', name: 'export', methods: ['GET'])]
     public function export(Request $request): Response
     {
-        $columns = array_values(
-            array_filter(
-                $request->query->all('columns'),
-                static fn (mixed $value): bool => is_string($value) && $value !== ''
-            )
-        );
-
-        $defaultRequest = new ExportSubscriberRequest();
-
         $exportRequest = new ExportSubscriberRequest(
             dateType: (string) $request->query->get('date_type', 'any'),
             listId: $request->query->has('list_id') ? $request->query->getInt('list_id') : null,
             dateFrom: $request->query->get('date_from') ?: null,
             dateTo: $request->query->get('date_to') ?: null,
-            columns: $columns === [] ? $defaultRequest->columns : $columns
+            columns: array_values(array_filter($request->query->all('columns')))
         );
 
         $upstreamResponse = $this->subscribersClient->exportSubscribers($exportRequest);
 
-        $content = (string) $upstreamResponse->getBody();
-
         $contentType = $upstreamResponse->getHeaderLine('Content-Type');
         if ($contentType === '') {
             $contentType = 'text/csv; charset=UTF-8';
@@ -128,10 +101,46 @@ public function export(Request $request): Response
             );
         }
 
-        $response = new Response($content);
+        $body = $upstreamResponse->getBody();
+        $response = new StreamedResponse(
+            static function () use ($body): void {
+                if ($body->isSeekable()) {
+                    $body->rewind();
+                }
+                while (! $body->eof()) {
+                    echo $body->read(8192);
+                }
+            },
+            $upstreamResponse->getStatusCode()
+        );
         $response->headers->set('Content-Type', $contentType);
         $response->headers->set('Content-Disposition', $contentDisposition);
 
         return $response;
     }
+
+    private function normalize(SubscriberCollection $collection, ?int $prevId, ?int $afterId): array
+    {
+        return [
+            'items' => array_map(static function (Subscriber $subscriber) {
+                return [
+                    'id' => $subscriber->id,
+                    'email' => $subscriber->email,
+                    'confirmed' => $subscriber->confirmed,
+                    'blacklisted' => $subscriber->blacklisted,
+                    'createdAt' => (new DateTimeImmutable($subscriber->createdAt))->format('Y-m-d H:i:s'),
+                    'uniqueId' => $subscriber->uniqueId,
+                    'listCount' => count($subscriber->subscribedLists),
+                ];
+            }, $collection->items ?? []),
+            'pagination' => [
+                'limit' => $collection->pagination->limit,
+                'afterId' => $collection->pagination->nextCursor,
+                'hasMore' => $collection->pagination->hasMore ,
+                'total' => $collection->pagination->total,
+                'prevId' => $prevId,
+                'isFirstPage' => $afterId === null,
+            ],
+        ];
+    }
 }