fix(bindings): thread adminToken through PilotPolicySet#14
Merged
Conversation
common's driver.PolicySet gained a third `adminToken string` parameter in v0.4.4. libpilot's `bindings.go` was still calling the old 2-arg form, so the whole CGO shim has been failing to build on main since 2026-06-06. Adds a fourth C argument (`adminToken *C.char`) to PilotPolicySet, mirroring the convention PilotBroadcast already follows. Empty strings are valid — the daemon side treats an absent token the same as "no admin auth attempted." This is a C ABI break, but the library has been uncompilable for three days; anyone embedding it can't be. Re-publishing as v0.x with the new symbol shape is the right call. go.mod tidy also bumps the sibling deps that drifted alongside: common 0.4.3 → 0.4.8 runtime 0.1.0 → 0.3.1 handshake 0.1.0 → 0.2.1 policy 0.1.0 → 0.2.2 trustedagents 0.1.0 → 0.2.3 Build + unit tests pass.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`common`'s `driver.PolicySet` gained a third `adminToken string`
parameter in v0.4.4. libpilot's `bindings.go` was still calling the
old 2-arg form, so the whole CGO shim has been failing to build on
main since 2026-06-06.
This adds a fourth C argument (`adminToken *C.char`) to
`PilotPolicySet`, mirroring the convention `PilotBroadcast` already
follows (
bindings.go:512for comparison). Empty strings are valid —the daemon side treats an absent token the same as "no admin auth
attempted."
This is a C ABI break, but the library has been uncompilable for three
days; anyone embedding it can't be. Re-publishing as v0.x with the new
symbol shape is the right call.
`go mod tidy` also bumps the sibling deps that had drifted alongside:
Test plan
to pass a fourth `adminToken` argument. Pass an empty string `""`
for unchanged behaviour.