fix(ci): tolerate upstream test-import drift in tidy step + bump deps#12
Merged
Merged
Conversation
CI's `Tidy (webhook) go.mod (absorb sibling drift)` step was failing
because handshake@v0.1.0's *tests* (not its main code) import paths
that were moved from TeoSlayer/pilotprotocol into pilot-protocol/common
during the recent extraction. Strict `go mod tidy` exits non-zero on
those broken transitive test imports even though webhook's own
build + tests are fine.
Two fixes:
1. Bump direct deps to current versions so webhook's own go.mod
reflects the new layout: handshake 0.1.0 → 0.2.1, common 0.2.0
→ 0.4.8.
2. Use `go mod tidy -e` so a transitive *test* import we don't
control doesn't fail CI. The follow-up build + test steps are
the real gate; tidy is just convenience.
Reproduces locally: `go test ./... -count=1 -short` passes; only the
strict tidy was red.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI's `Tidy (webhook) go.mod (absorb sibling drift)` step has been failing on every push since the type extraction from `TeoSlayer/pilotprotocol` into `pilot-protocol/common`. The cause is that `handshake@v0.1.0`'s tests (not its main code) still import the old, now-removed paths, and strict `go mod tidy` exits non-zero on those broken transitive test imports.
webhook's own build + tests are fine — reproducible locally with `go test ./... -count=1 -short`. Only the strict-tidy gate was red.
Changes
Test plan