From 4365acbf8c9f7abff36e39397503e5966dd17cd4 Mon Sep 17 00:00:00 2001 From: BSd3v <82055130+BSd3v@users.noreply.github.com> Date: Wed, 22 Apr 2026 11:21:47 -0400 Subject: [PATCH 1/6] adding PR test for changelog entry --- .github/workflows/change_log.yml | 58 ++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 .github/workflows/change_log.yml diff --git a/.github/workflows/change_log.yml b/.github/workflows/change_log.yml new file mode 100644 index 00000000..f5df225f --- /dev/null +++ b/.github/workflows/change_log.yml @@ -0,0 +1,58 @@ +# yaml +name: Check changelog entry + +on: + pull_request: + types: [opened, synchronize, reopened] + push: + branches: + - '**' + +jobs: + check-changelog: + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@v4 + with: + fetch-depth: 0 + + - name: Determine changed files and require changelog update + env: + EVENT_NAME: ${{ github.event_name }} + PR_BASE_REF: ${{ github.event.pull_request.base.ref || '' }} + BEFORE: ${{ github.event.before }} + SHA: ${{ github.sha }} + run: | + set -euo pipefail + + echo "Event: $EVENT_NAME" + + if [ "$EVENT_NAME" = "pull_request" ]; then + if [ -z "$PR_BASE_REF" ]; then + echo "Pull request base ref not provided." + exit 1 + fi + echo "Fetching base ref origin/$PR_BASE_REF" + git fetch origin "$PR_BASE_REF":refs/remotes/origin/"$PR_BASE_REF" || true + changed=$(git diff --name-only "origin/$PR_BASE_REF...HEAD" || true) + else + if [ "$BEFORE" = "0000000000000000000000000000000000000000" ]; then + # new branch or forced push: list files in the commit + changed=$(git show --name-only --pretty="" "$SHA" || true) + else + changed=$(git diff --name-only "$BEFORE...$SHA" || true) + fi + fi + + echo "Changed files:" + echo "$changed" | sed 's/^/ - /' + + # match: CHANGELOG.md, NEWS.md, any file under changelog(s)/ or docs/changelog/ + echo "$changed" | grep -E '(^CHANGELOG\.md$|^NEWS\.md$|(^|/)changelog(/|$)|(^|/)changelogs(/|$)|(^|/)docs/changelog(/|$))' >/dev/null 2>&1 || { + echo "::error::No changelog changes detected." + echo "Please add or update a changelog entry (e.g. update `CHANGELOG.md` or add a file under `changelog/`)." + exit 1 + } + + echo "Changelog change detected. OK." From 324770e4b456a68e15ded1a061359c8074664986 Mon Sep 17 00:00:00 2001 From: BSd3v <82055130+BSd3v@users.noreply.github.com> Date: Wed, 22 Apr 2026 11:27:23 -0400 Subject: [PATCH 2/6] adding changelog updates detection --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2079272a..086a715b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,8 @@ This project adheres to [Semantic Versioning](https://semver.org/). Links "DE#nnn" prior to version 2.0 point to the Dash Enterprise closed-source Dash AG Grid repo ## [unreleased] +### Added +- [#453](https://github.com/plotly/dash-ag-grid/pull/453) Test for changelog entry ## [35.2.0] - 2026-04-03 From 52df03776658425525fe9420fcc5f6fb1ea7bac3 Mon Sep 17 00:00:00 2001 From: BSd3v <82055130+BSd3v@users.noreply.github.com> Date: Wed, 22 Apr 2026 11:32:15 -0400 Subject: [PATCH 3/6] adjusting test to only be on PR and renaming file for schema --- .github/workflows/{change_log.yml => change-log.yml} | 3 --- 1 file changed, 3 deletions(-) rename .github/workflows/{change_log.yml => change-log.yml} (98%) diff --git a/.github/workflows/change_log.yml b/.github/workflows/change-log.yml similarity index 98% rename from .github/workflows/change_log.yml rename to .github/workflows/change-log.yml index f5df225f..af45d401 100644 --- a/.github/workflows/change_log.yml +++ b/.github/workflows/change-log.yml @@ -4,9 +4,6 @@ name: Check changelog entry on: pull_request: types: [opened, synchronize, reopened] - push: - branches: - - '**' jobs: check-changelog: From 89c044fcb17c1772bd5e942388ed67763285486f Mon Sep 17 00:00:00 2001 From: BSd3v <82055130+BSd3v@users.noreply.github.com> Date: Wed, 22 Apr 2026 11:33:42 -0400 Subject: [PATCH 4/6] Update .github/workflows/change-log.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .github/workflows/change-log.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/change-log.yml b/.github/workflows/change-log.yml index af45d401..ab65f96c 100644 --- a/.github/workflows/change-log.yml +++ b/.github/workflows/change-log.yml @@ -32,13 +32,13 @@ jobs: fi echo "Fetching base ref origin/$PR_BASE_REF" git fetch origin "$PR_BASE_REF":refs/remotes/origin/"$PR_BASE_REF" || true - changed=$(git diff --name-only "origin/$PR_BASE_REF...HEAD" || true) + changed=$(git diff --name-only "origin/$PR_BASE_REF...HEAD") else if [ "$BEFORE" = "0000000000000000000000000000000000000000" ]; then # new branch or forced push: list files in the commit - changed=$(git show --name-only --pretty="" "$SHA" || true) + changed=$(git show --name-only --pretty="" "$SHA") else - changed=$(git diff --name-only "$BEFORE...$SHA" || true) + changed=$(git diff --name-only "$BEFORE...$SHA") fi fi From 58d03055dd0cd663815b10e586d96cdb5281187b Mon Sep 17 00:00:00 2001 From: BSd3v <82055130+BSd3v@users.noreply.github.com> Date: Wed, 22 Apr 2026 11:38:19 -0400 Subject: [PATCH 5/6] Update .github/workflows/change-log.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .github/workflows/change-log.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/change-log.yml b/.github/workflows/change-log.yml index ab65f96c..70f9ab8c 100644 --- a/.github/workflows/change-log.yml +++ b/.github/workflows/change-log.yml @@ -5,6 +5,8 @@ on: pull_request: types: [opened, synchronize, reopened] +permissions: + contents: read jobs: check-changelog: runs-on: ubuntu-latest From 27de13eef5b3dd3c812441872800fd7af3c57f12 Mon Sep 17 00:00:00 2001 From: BSd3v <82055130+BSd3v@users.noreply.github.com> Date: Wed, 22 Apr 2026 11:38:52 -0400 Subject: [PATCH 6/6] Update .github/workflows/change-log.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .github/workflows/change-log.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/change-log.yml b/.github/workflows/change-log.yml index 70f9ab8c..bb49387a 100644 --- a/.github/workflows/change-log.yml +++ b/.github/workflows/change-log.yml @@ -33,7 +33,10 @@ jobs: exit 1 fi echo "Fetching base ref origin/$PR_BASE_REF" - git fetch origin "$PR_BASE_REF":refs/remotes/origin/"$PR_BASE_REF" || true + if ! git fetch origin "$PR_BASE_REF":refs/remotes/origin/"$PR_BASE_REF"; then + echo "::error::Failed to fetch pull request base ref origin/$PR_BASE_REF." + exit 1 + fi changed=$(git diff --name-only "origin/$PR_BASE_REF...HEAD") else if [ "$BEFORE" = "0000000000000000000000000000000000000000" ]; then