You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you are implementing a new feature that involves regl shaders, or if you are
166
-
making changes that affect the usage of regl shaders, you would need to run
166
+
making changes that affect the usage of regl shaders, you would need to regenerate the precompiled regl shader code.
167
+
168
+
This is needed because regl performs codegen in runtime which breaks CSP
169
+
compliance, and so for strict builds we pre-generate regl shader code here.
170
+
171
+
The CI pipeline will automatically detect when regl-related files have changed and
172
+
run the codegen process. If the precompiled shaders are out of date, the
173
+
`check-regl-codegen` job will fail and upload a `regl-codegen` artifact containing
174
+
the updated files. To fix this:
175
+
176
+
1. Download the `regl-codegen` artifact from the failed workflow run
177
+
2. Copy the updated files into your working tree
178
+
3. Commit and push the changes to your pull request
179
+
180
+
Alternatively, you can regenerate the code locally by running:
167
181
168
182
```bash
169
183
npm run regl-codegen
170
184
```
171
185
172
-
to regenerate the regl code. This will prompt you to open a browser window. This will then run through all
173
-
traces with 'regl' in the tags, and store the captured code into
174
-
[src/generated/regl-codegen](https://github.com/plotly/plotly.js/blob/master/src/generated/regl-codegen). If no updates are necessary, it will be a no-op, but if there are changes, you will need to commit them.
175
-
176
-
This is needed because regl performs codegen in runtime which breaks CSP
177
-
compliance, and so for strict builds we pre-generate regl shader code here.
186
+
This will prompt you to open a browser window, run through all traces with 'regl'
0 commit comments