Skip to content

Commit f4c2d81

Browse files
committed
small cleanup
1 parent bdbcc5e commit f4c2d81

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

.github/workflows/upload-dev-build.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,18 @@ jobs:
3333

3434
- name: Check if artifact exists
3535
if: steps.download-artifact.outcome != 'success'
36+
env:
37+
RUN_ID: ${{ github.event.workflow_run.id || inputs.run_id }}
3638
run: |
37-
echo "No build artifact found for this run. Skipping upload."
39+
echo "No build artifact found for $RUN_ID. Skipping upload."
3840
exit 0
3941
4042
- name: Setup metadata and prepare folders
4143
id: setup-metadata
4244
env:
4345
GH_TOKEN: ${{ github.token }}
46+
PR_NUM: ${{ github.event.workflow_run.pull_requests[0].number || inputs.pr_number }}
4447
run: |
45-
# Get PR number from triggering workflow, or from manual input
46-
PR_NUM="${{ github.event.workflow_run.pull_requests[0].number || inputs.pr_number }}"
4748
# Get SHA from triggering workflow, or from manual input
4849
if [ "${{ github.event_name }}" == "workflow_run" ]; then
4950
SHA="${{ github.event.workflow_run.head_sha }}"
@@ -112,5 +113,5 @@ jobs:
112113
BASE="https://plotly.github.io/plotly.js-dev-builds/upload/pr-${{ steps.setup-metadata.outputs.PR_NUM }}"
113114
echo "### PR Build Uploaded" >> $GITHUB_STEP_SUMMARY
114115
echo "Builds for PR #${{ steps.setup-metadata.outputs.PR_NUM }} are available:" >> $GITHUB_STEP_SUMMARY
115-
echo "- Latest build for this PR:[$BASE/latest/plotly.min.js]($BASE/latest/plotly.min.js)" >> $GITHUB_STEP_SUMMARY
116+
echo "- Latest build for this PR: [$BASE/latest/plotly.min.js]($BASE/latest/plotly.min.js)" >> $GITHUB_STEP_SUMMARY
116117
echo "- Build for this commit (permalink): [$BASE/${{ steps.setup-metadata.outputs.SHA }}/plotly.min.js]($BASE/${{ steps.setup-metadata.outputs.SHA }}/plotly.min.js)" >> $GITHUB_STEP_SUMMARY

0 commit comments

Comments
 (0)