Fix [note] colour not updating, fix messbox assertion

Author: timothyschoen

Source/Objects/MessboxObject.h

@@ -175,8 +175,10 @@ class MessboxObject final : public ObjectBase
 
     void hideEditor() override
     {
-        cnv->grabKeyboardFocus();
-        repaint();
+        if(cnv->isVisible()) {
+            cnv->grabKeyboardFocus();
+            repaint();
+        }
     }
 
     bool isEditorShown() override

Source/Objects/NoteObject.h

@@ -179,6 +179,7 @@ class NoteObject final : public ObjectBase, public AsyncUpdater {
     {
         auto const newFont = getFont();
 
+        noteEditor.setColour(TextEditor::textColourId, Colour::fromString(primaryColour.toString()));
         noteEditor.setIndents(0, 2);
         noteEditor.setFont(newFont);
         noteEditor.setText(currentNoteText);
@@ -192,7 +193,6 @@ class NoteObject final : public ObjectBase, public AsyncUpdater {
             noteEditor.setJustification(Justification::topRight);
         }
 
-        noteEditor.setColour(TextEditor::textColourId, Colour::fromString(primaryColour.toString()));
         getLookAndFeel().setColour(Label::textWhenEditingColourId, cnv->editor->getLookAndFeel().findColour(Label::textWhenEditingColourId));
         getLookAndFeel().setColour(Label::textColourId, cnv->editor->getLookAndFeel().findColour(Label::textColourId));
     }