Context
After PR #53, has_unsupported_isle_instructions only checks for Instruction::Unknown(_). The function still does recursive block traversal, but it's now equivalent to the simpler has_unknown_instructions helper.
TODO
Consider consolidating:
- Remove
has_unsupported_isle_instructions and has_unsupported_isle_instructions_in_block
- Replace all call sites with
has_unknown_instructions (which already exists and does the same flat check)
- Or: make
has_unknown_instructions recursive like the unsupported version (it currently only checks top-level instructions)
Files
loom-core/src/lib.rs: Both functions defined around line 6600, used in ~15 optimization passes
Context
After PR #53,
has_unsupported_isle_instructionsonly checks forInstruction::Unknown(_). The function still does recursive block traversal, but it's now equivalent to the simplerhas_unknown_instructionshelper.TODO
Consider consolidating:
has_unsupported_isle_instructionsandhas_unsupported_isle_instructions_in_blockhas_unknown_instructions(which already exists and does the same flat check)has_unknown_instructionsrecursive like the unsupported version (it currently only checks top-level instructions)Files
loom-core/src/lib.rs: Both functions defined around line 6600, used in ~15 optimization passes