Address feedback on MR

This commit addresses feedback on MR by removing
unecessary checks and addit __getitem__ method

Signed-off-by: Rohan Devasthale <rdevasth@redhat.com>

Author: rd4398

src/fromager/resolver.py

@@ -1001,13 +1001,7 @@ def find_candidates(self, identifier: str) -> Candidates:
         """
         candidates: list[Candidate] = []
         for version in self.version_map.versions():
-            url = self.version_map._content[version]
-            if not isinstance(url, str):
-                logger.warning(
-                    f"{identifier}: skipping version {version} with non-string URL: {type(url)}"
-                )
-                continue
-
+            url = self.version_map[version]
             candidate = Candidate(
                 name=identifier,
                 version=version,

src/fromager/versionmap.py

@@ -30,6 +30,16 @@ def add(self, key: Version | str, value: typing.Any) -> None:
             key = Version(key)
         self._content[key] = value
 
+    def __getitem__(self, key: Version | str) -> typing.Any:
+        """Get the value associated with a version
+
+        String keys are converted to Version instances. Raises KeyError if the
+        version is not found.
+        """
+        if not isinstance(key, Version):
+            key = Version(key)
+        return self._content[key]
+
     def versions(self) -> typing.Iterable[Version]:
         """Return the known versions, sorted in descending order."""
         return reversed(sorted(self._content.keys()))

tests/test_versionmap.py

@@ -100,3 +100,26 @@ def test_no_match() -> None:
         m.lookup(Requirement("pkg"), Requirement("pkg<1.0"))
     with pytest.raises(ValueError):
         m.lookup(Requirement("pkg>1.0"), Requirement("pkg<1.0"))
+
+
+def test_getitem() -> None:
+    m = VersionMap(
+        {
+            "1.2": "value for 1.2",
+            Version("1.3"): "value for 1.3",
+            "1.0": "value for 1.0",
+        }
+    )
+    # Access by Version object
+    assert m[Version("1.2")] == "value for 1.2"
+    assert m[Version("1.3")] == "value for 1.3"
+
+    # Access by string (auto-converted to Version)
+    assert m["1.2"] == "value for 1.2"
+    assert m["1.0"] == "value for 1.0"
+
+    # Non-existent version raises KeyError
+    with pytest.raises(KeyError):
+        m[Version("2.0")]
+    with pytest.raises(KeyError):
+        m["2.0"]