backend: clean up unused code paths

Author: pablogsal

backend/app/auth.py

@@ -1,10 +1,9 @@
 """Authentication utilities for the Memory Tracker API."""
 
-from fastapi import Depends, HTTPException, status, Header
+from fastapi import Depends, Header
 from fastapi.security import HTTPBearer, HTTPAuthorizationCredentials
 from sqlalchemy.ext.asyncio import AsyncSession
 from typing import Annotated
-import logging
 
 from . import models, crud
 from .database import get_database

backend/app/config.py

@@ -3,9 +3,8 @@
 All settings are loaded from environment variables with sensible defaults.
 """
 
-from typing import List, Optional, Union
+from typing import List
 from pydantic_settings import BaseSettings
-from pydantic import field_validator
 from functools import lru_cache
 
 

backend/app/logging_utils.py

@@ -1,7 +1,7 @@
 """Logging utilities for sanitizing sensitive data."""
 
 import re
-from typing import Any, Dict, List, Union
+from typing import Any, Dict, List
 
 # Patterns for sensitive data
 SENSITIVE_PATTERNS = [

backend/app/oauth.py

@@ -4,9 +4,9 @@
 
 import secrets
 import logging
-from typing import Optional, Dict, Any
+from typing import Optional
 from authlib.integrations.httpx_client import AsyncOAuth2Client
-from fastapi import HTTPException, Request
+from fastapi import HTTPException
 from pydantic import BaseModel
 from sqlalchemy.ext.asyncio import AsyncSession
 

backend/app/routers/binaries.py

@@ -19,7 +19,7 @@ async def get_binaries(db: AsyncSession = Depends(get_database)):
 
     try:
         binaries = await crud.get_binaries(db)
-        logger.info(f"Successfully retrieved binaries", extra={"count": len(binaries)})
+        logger.info("Successfully retrieved binaries", extra={"count": len(binaries)})
 
         return [
             schemas.Binary(
@@ -34,7 +34,7 @@ async def get_binaries(db: AsyncSession = Depends(get_database)):
             for binary in binaries
         ]
     except Exception as e:
-        logger.error(f"Failed to fetch binaries", extra={"error": str(e)})
+        logger.error("Failed to fetch binaries", extra={"error": str(e)})
         raise HTTPException(status_code=500, detail="Failed to fetch binaries")
 
 

backend/app/routers/commits.py

@@ -20,11 +20,11 @@ async def get_commits(
     db: AsyncSession = Depends(get_database),
 ):
     logger = get_logger("api.commits")
-    logger.info(f"Fetching commits", extra={"skip": skip, "limit": limit})
+    logger.info("Fetching commits", extra={"skip": skip, "limit": limit})
 
     try:
         commits = await crud.get_commits(db, skip=skip, limit=limit)
-        logger.info(f"Successfully retrieved commits", extra={"count": len(commits)})
+        logger.info("Successfully retrieved commits", extra={"count": len(commits)})
 
         return [
             schemas.Commit(
@@ -41,23 +41,23 @@ async def get_commits(
             for commit in commits
         ]
     except Exception as e:
-        logger.error(f"Failed to fetch commits", extra={"error": str(e)})
+        logger.error("Failed to fetch commits", extra={"error": str(e)})
         raise HTTPException(status_code=500, detail="Failed to fetch commits")
 
 
 @router.get("/commits/{sha}", response_model=schemas.Commit)
 async def get_commit(sha: str, db: AsyncSession = Depends(get_database)):
     logger = get_logger("api.commits")
-    logger.info(f"Fetching commit by SHA", extra={"sha": sha})
+    logger.info("Fetching commit by SHA", extra={"sha": sha})
 
     try:
         commit = await crud.get_commit_by_sha(db, sha=sha)
         if commit is None:
-            logger.warning(f"Commit not found", extra={"sha": sha})
+            logger.warning("Commit not found", extra={"sha": sha})
             raise HTTPException(status_code=404, detail="Commit not found")
 
         logger.info(
-            f"Successfully retrieved commit",
+            "Successfully retrieved commit",
             extra={
                 "sha": commit.sha[:8],
                 "author": commit.author,
@@ -79,7 +79,7 @@ async def get_commit(sha: str, db: AsyncSession = Depends(get_database)):
     except HTTPException:
         raise
     except Exception as e:
-        logger.error(f"Failed to fetch commit", extra={"sha": sha, "error": str(e)})
+        logger.error("Failed to fetch commit", extra={"sha": sha, "error": str(e)})
         raise HTTPException(status_code=500, detail="Failed to fetch commit")
 
 

backend/scripts/init_db.py

@@ -11,7 +11,7 @@
 # Add the parent directory to the path so we can import from app
 sys.path.insert(0, os.path.join(os.path.dirname(__file__), ".."))
 
-from app.database import create_tables, drop_tables, get_database
+from app.database import get_database
 from app import crud
 from app.config import get_settings
 
@@ -65,14 +65,6 @@ async def init_database():
     try:
         # Import models to ensure they're registered
         from app.models import (
-            AdminUser,
-            AdminSession,
-            AuthToken,
-            Commit,
-            Binary,
-            Environment,
-            Run,
-            BenchmarkResult,
             Base,
         )
         from app.database import create_database_engine
@@ -128,7 +120,6 @@ async def reset_database():
             Base,
         )
         from app.database import create_database_engine
-        from sqlalchemy.ext.asyncio import create_async_engine
 
         # Create a fresh engine with current settings
         engine = create_database_engine()

backend/scripts/populate_db.py

@@ -379,7 +379,7 @@ async def populate_database(database_url: Optional[str] = None):
                 await db.flush()
                 print(f"✅ Created {len(binary_objects)} new binaries")
             else:
-                print(f"✅ All binaries already exist")
+                print("✅ All binaries already exist")
 
             # Use all binaries (existing + new) for runs
             all_binary_objects = existing_binaries + binary_objects
@@ -404,7 +404,7 @@ async def populate_database(database_url: Optional[str] = None):
                 await db.flush()
                 print(f"✅ Created {len(environment_objects)} new environments")
             else:
-                print(f"✅ All environments already exist")
+                print("✅ All environments already exist")
 
             # Use all environments (existing + new) for runs
             all_environment_objects = existing_environments + environment_objects
@@ -487,7 +487,7 @@ async def populate_database(database_url: Optional[str] = None):
             # Commit everything at once
             await db.commit()
 
-            print(f"\n🎉 Database populated successfully!")
+            print("\n🎉 Database populated successfully!")
             print(f"   - {len(commit_objects)} commits (100 per Python version)")
             print(
                 f"   - {len(binary_objects)} new binaries ({len(all_binary_objects)} total)"

backend/scripts/populate_simple_data.py

@@ -15,7 +15,7 @@
 sys.path.insert(0, os.path.join(os.path.dirname(__file__), ".."))
 
 from app.database import AsyncSessionLocal
-from app import models, schemas, crud
+from app import models, schemas
 
 
 # Mock data generators
@@ -403,7 +403,7 @@ async def populate_database():
             # Commit everything at once
             await db.commit()
 
-            print(f"\n🎉 Database populated with OBVIOUS TEST DATA!")
+            print("\n🎉 Database populated with OBVIOUS TEST DATA!")
             print(f"   - {len(commit_objects)} commits (2 per Python version)")
             print(f"   - {len(binary_objects)} binaries (default, debug, nogil)")
             print(f"   - {len(environment_objects)} environments (gcc-11, clang-14)")
@@ -413,10 +413,10 @@ async def populate_database():
             print(
                 f"   - {len(result_objects)} benchmark results (3 benchmarks per run)"
             )
-            print(f"\n📊 MEMORY VALUES FOR VERIFICATION:")
-            print(f"   Benchmark A: Default=1MB, Debug=1.5MB, NoGIL=0.8MB")
-            print(f"   Benchmark B: Default=2MB, Debug=3MB, NoGIL=1.6MB")
-            print(f"   Benchmark C: Default=10MB, Debug=15MB, NoGIL=8MB")
+            print("\n📊 MEMORY VALUES FOR VERIFICATION:")
+            print("   Benchmark A: Default=1MB, Debug=1.5MB, NoGIL=0.8MB")
+            print("   Benchmark B: Default=2MB, Debug=3MB, NoGIL=1.6MB")
+            print("   Benchmark C: Default=10MB, Debug=15MB, NoGIL=8MB")
 
         except Exception as e:
             print(f"❌ Error populating database: {e}")