Skip to content

Commit 48ef89e

Browse files
committed
Move version check to task list definition
1 parent 4937eff commit 48ef89e

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

run_release.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -439,9 +439,6 @@ def check_cpython_repo_is_clean(db: ReleaseShelf) -> None:
439439

440440
def check_magic_number(db: ReleaseShelf) -> None:
441441
release_tag = db["release"]
442-
if release_tag.major == 3 and release_tag.minor <= 13:
443-
return
444-
445442
if release_tag.is_final or release_tag.is_release_candidate:
446443

447444
def out(msg: str) -> None:
@@ -1427,6 +1424,7 @@ def _api_key(api_key: str) -> str:
14271424
)
14281425

14291426
release_tag = release_mod.Tag(args.release)
1427+
magic = release_tag.as_tuple() >= (3, 14)
14301428
no_gpg = release_tag.as_tuple() >= (3, 14) # see PEP 761
14311429
tasks = [
14321430
Task(check_git, "Checking Git is available"),
@@ -1443,7 +1441,11 @@ def _api_key(api_key: str) -> str:
14431441
Task(check_sigstore_client, "Checking Sigstore CLI"),
14441442
Task(check_buildbots, "Check buildbots are good"),
14451443
Task(check_cpython_repo_is_clean, "Checking Git repository is clean"),
1446-
Task(check_magic_number, "Checking the magic number is up-to-date"),
1444+
*(
1445+
[Task(check_magic_number, "Checking the magic number is up-to-date")]
1446+
if magic
1447+
else []
1448+
),
14471449
Task(prepare_temporary_branch, "Checking out a temporary release branch"),
14481450
Task(run_blurb_release, "Run blurb release"),
14491451
Task(check_cpython_repo_is_clean, "Checking Git repository is clean"),

0 commit comments

Comments
 (0)