Commit aa68ac6
[ET-VK][custom_ops] Standardize binary filenames to test_*.cpp
Five custom_ops test binaries did not follow the test_*.cpp naming convention used by the other 16. Rename them via sl mv (history-preserving) in both xplat and fbcode mirrors:
- add.cpp -> test_add.cpp
- choose_qparams_per_row.cpp -> test_choose_qparams_per_row.cpp
- q4gsw_linear.cpp -> test_q4gsw_linear.cpp
- q8csw_conv2d.cpp -> test_q8csw_conv2d.cpp
- q8csw_linear.cpp -> test_q8csw_linear.cpp
Also add a Buck target for test_q8ta_unary -- the source file existed but no target was defined, leaving the binary unbuildable in fbsource (xplat/executorch/backends/vulkan/test/custom_ops:test_q8ta_unary now resolves).
Updates to references:
- targets.bzl (xplat + fbcode mirrors) -- five define_custom_op_test_binary() call sites renamed; one new entry for test_q8ta_unary.
- CMakeLists.txt (xplat + fbcode mirrors) -- five add_operator_prototype() call sites renamed. test_q8ta_unary is not added to CMake here since it was not in the prior CMake list (existing latent gap; orthogonal to this rename).
- tools/skycastle/.../executorch_vulkan_eureka_unit_tests.sky -- four CI target paths updated. Display labels are also updated to match the binary name (test_q8csw_linear, etc.), consistent with the convention used by adjacent test_q8ta_* entries.
- tools/skycastle/.../executorch_vulkan_gpu_host_unit_tests.sky -- three CI target paths + labels updated (this file does not run q8csw_conv2d).
- fbcode/executorch/oss/.github/workflows/pull.yml + xplat mirror -- five OSS CI references updated, including the build_and_run.sh argument that runs the renamed test_add binary.
Differential Revision: [D105059945](https://our.internmc.facebook.com/intern/diff/D105059945/)
ghstack-source-id: 381655469
Pull Request resolved: #195711 parent 2f94176 commit aa68ac6
8 files changed
Lines changed: 16 additions & 15 deletions
File tree
- .github/workflows
- backends/vulkan/test/custom_ops
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1489 | 1489 | | |
1490 | 1490 | | |
1491 | 1491 | | |
1492 | | - | |
1493 | | - | |
1494 | | - | |
1495 | | - | |
1496 | | - | |
| 1492 | + | |
| 1493 | + | |
| 1494 | + | |
| 1495 | + | |
| 1496 | + | |
1497 | 1497 | | |
1498 | 1498 | | |
1499 | 1499 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| 102 | + | |
102 | 103 | | |
103 | 104 | | |
104 | 105 | | |
| |||
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
0 commit comments