Skip to content

Commit f3f49f2

Browse files
committed
core/desktopentry: sort fallback entries for terminal resolution my id
1 parent 7927cb0 commit f3f49f2

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

src/core/desktopentry.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -837,7 +837,11 @@ void DesktopEntryManager::onScanCompleted(const QList<ParsedDesktopEntryData>& s
837837
}
838838

839839
// Fallback phase: remaining TerminalEmulator entries.
840-
for (auto* entry: this->desktopEntries.values()) {
840+
// XXX: Spec says fallback entry order is undefined, but we sort by ID
841+
// for deterministic behavior.
842+
auto fallbackEntries = this->desktopEntries.values();
843+
std::ranges::sort(fallbackEntries, {}, &DesktopEntry::mId);
844+
for (auto* entry: fallbackEntries) {
841845
if (addedIds.contains(entry->mId)) continue;
842846
if (!isValidTerminal(entry)) continue;
843847
if (excludedIds.contains(entry->mId) && !protectedIds.contains(entry->mId)) continue;

0 commit comments

Comments
 (0)