From 306b6cb2aa2ad88c0dc166188b83663030807503 Mon Sep 17 00:00:00 2001 From: Rob Hogan Date: Wed, 3 Jun 2026 09:10:28 -0700 Subject: [PATCH] Consistently name argument, unbreak Android OSS build Summary: https://github.com/facebook/react-native/commit/57eb56fbf5658170026b82bba04358e58237eb70 broke Android OSS due to a variable rename that I missed in a rebase. Eg: https://github.com/facebook/react-native/actions/runs/26894263379/job/79328683517 ``` e: warnings found and -Werror specified w: file:///__w/react-native/react-native/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/MultipartStreamReaderTest.kt:203:15 The corresponding parameter in the supertype 'CallCountTrackingChunkCallback' is named 'isLastChunk'. This may cause problems when calling this function with named arguments. > Task :packages:react-native:ReactAndroid:compileDebugOptimizedUnitTestKotlin > Task :packages:react-native:ReactAndroid:compileDebugOptimizedUnitTestKotlin FAILED > Task :react-native_popup-menu-android:extractReleaseAnnotations e: warnings found and -Werror specified ``` Changelog: Internal Differential Revision: D107397221 --- .../facebook/react/devsupport/MultipartStreamReaderTest.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/MultipartStreamReaderTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/MultipartStreamReaderTest.kt index e9903368535f..4e4399da89b6 100644 --- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/MultipartStreamReaderTest.kt +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/MultipartStreamReaderTest.kt @@ -200,9 +200,9 @@ class MultipartStreamReaderTest { override fun onChunkComplete( headers: Map, body: BufferedSource, - done: Boolean, + isLastChunk: Boolean, ) { - super.onChunkComplete(headers, body, done) + super.onChunkComplete(headers, body, isLastChunk) // Lookup using canonical case should still work. assertThat(headers["Content-Type"]).isEqualTo("application/json")