Add telco-core 4.22 and preGA bits#159
Open
agurenko wants to merge 1 commit into
Open
Conversation
750d0cc to
639d16f
Compare
62b1fa8 to
a3821d8
Compare
a3821d8 to
d1f23c5
Compare
d1f23c5 to
dc7420e
Compare
akrzos
requested changes
May 20, 2026
Member
akrzos
left a comment
There was a problem hiding this comment.
Looks good but we need a few small changes, between my diffs and claude there are only a few points to address considering the size of the PR.
● Here's the summary:
1. configurationstate.yaml — Only difference is the PR version is missing a trailing newline. Trivial but technically divergent from upstream.
2. optional/storage-lso/ — This entire directory (4 files: StorageLV.yaml, StorageNS.yaml, StorageOperGroup.yaml, StorageSubscription.yaml) exists in the PR but not in the upstream
telco-reference 4.22 branch. This was likely carried over from the 4.20 reference CRs — it appears to be an addition specific to this repo's test configuration, not part of the upstream
telco-core 4.22 reference.
Everything else matches exactly.
Member
There was a problem hiding this comment.
My diff on overlay:
$ diff 4.20/telco-reference/telco-core/configuration/core-overlay.yaml 4.22/telco-reference/telco-core/configuration/core-overlay.yaml
5c5
< name: core-overlay-19
---
> name: core-overlay-22
10,12c10,13
< clusterSelectors:
< common: "core"
< version: "4.20"
---
> labelSelector:
> matchLabels:
> common: "core"
> version: "4.22"
16c17
< - name: core-overlay-base-4.20
---
> - name: core-overlay-base-4.22
35a37,60
> # Cert-manager configuration (optional component)
> # - path: reference-crs/optional/cert-manager/certManagerClusterIssuer.yaml
> # patches:
> # - spec:
> # acme:
> # server: https://acme-v02.api.letsencrypt.org/directory
> # email: your-email@example.com
> # privateKeySecretRef:
> # name: acme-account-key
> # - path: reference-crs/optional/cert-manager/ingressCertificate.yaml
> # patches:
> # - spec:
> # commonName: "*.apps.example.com"
> # dnsNames:
> # - "*.apps.example.com"
> # - path: reference-crs/optional/cert-manager/ingressControllerConfig.yaml
> # - path: reference-crs/optional/cert-manager/apiServerCertificate.yaml
> # patches:
> # - spec:
> # commonName: "api.example.com"
> # dnsNames:
> # - "api.example.com"
> # - path: reference-crs/optional/cert-manager/apiServerConfig.yaml
>
37c62
< - name: core-overlay-config-4.20
---
> - name: core-overlay-config-4.22
109a135,175
> # TuneD performance patches for core
> - path: reference-crs/required/performance/TunedPerformancePatch.yaml
> patches:
> - metadata:
> name: telco-core-performance-patch
> spec:
> recommend:
> - machineConfigLabels:
> machineconfiguration.openshift.io/role: worker-1
> priority: 18
> profile: worker-profile-1
> - machineConfigLabels:
> machineconfiguration.openshift.io/role: worker-2
> priority: 18
> profile: worker-profile-2
> - machineConfigLabels:
> machineconfiguration.openshift.io/role: worker-3
> priority: 18
> profile: worker-profile-3
>
> # Tuned performance patch template for usage with custom profile names
>
> # - path: reference-crs/required/performance/TunedPerformancePatch.yaml
> # patches:
> # - metadata:
> # name: custom-telco-core-performance-patch
> # spec:
> # profile:
> # - name: custom-worker-profile
> # data: |
> # [main]
> # summary=Custom compute core performance tuning overrides
> # include=openshift-node-performance-worker-profile-x
> # [sysctl]
> # kernel.panic_on_unrecovered_nmi=1
> # recommend:
> # - machineConfigLabels:
> # machineconfiguration.openshift.io/role: worker-profile-x
> # priority: 18
> # profile: custom-worker-profile
>
230c296,298
< - name: config-monitoring-4.20
---
> - name: config-monitoring-4.22
> # For consistency the name of this policy will be updated in a future release:
> # - name: core-overlay-monitoring-4.22| size: 1G | ||
| nodeSelector: | ||
| node-role.kubernetes.io/worker-3: "" | ||
|
|
Member
There was a problem hiding this comment.
Looks like another manifest was included here called TunedPerformancePatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Telco Core 4.22 with PreGA capabilities