Skip to content

Commit 4de91cb

Browse files
committed
Simplify test fixture and refine test coverage
1 parent b76a3d9 commit 4de91cb

2 files changed

Lines changed: 1 addition & 14 deletions

File tree

atest/acceptance/keywords/draganddropframe.robot

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Drag And Drop Across Frames Returns To Default Content
2828
[Documentation] Verifies that the keyword returns to default content after execution.
2929
Wait Until Page Contains Element id=defaultSource 10s
3030
Drag And Drop Across Frames id=defaultSource id=target id=targetFrame
31-
Element Should Be Visible id=targetFrame
31+
Page Should Not Contain Element id=target
3232

3333
Drag And Drop Across Frames Hides Default Source Element
3434
[Documentation] Verifies that the default source element becomes hidden after a successful drop.
@@ -44,16 +44,6 @@ Drag And Drop Across Frames Hides Frame Source Element
4444
Element Should Not Be Visible id=frameSource
4545
Unselect Frame
4646

47-
Standard Drag And Drop Fails When Target Is Inside Frame
48-
[Documentation] Verifies that the standard Drag And Drop keyword cannot complete this cross-frame scenario.
49-
Wait Until Page Contains Element id=defaultSource 10s
50-
Run Keyword And Expect Error
51-
... Element with locator 'id=target' not found.
52-
... Drag And Drop id=defaultSource id=target
53-
Select Frame id=targetFrame
54-
Element Should Not Contain id=target Dropped Successfully!
55-
Unselect Frame
56-
5747
Drag And Drop Across Frames Fails With Invalid Target Frame
5848
[Documentation] Verifies that the keyword fails when the target frame locator is invalid.
5949
Wait Until Page Contains Element id=defaultSource 10s

atest/resources/html/frames/draganddrop.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,12 @@ <h2>Drag And Drop Across Frames Test Page</h2>
6262
</div>
6363

6464
<div id="dragGhost"></div>
65-
<div id="status">Not dropped</div>
6665

6766
<script>
6867
const sourceFrame = document.getElementById("sourceFrame");
6968
const targetFrame = document.getElementById("targetFrame");
7069
const defaultSource = document.getElementById("defaultSource");
7170
const dragGhost = document.getElementById("dragGhost");
72-
const status = document.getElementById("status");
7371

7472
let dragging = false;
7573
let activeSource = null;
@@ -248,7 +246,6 @@ <h2>Drag And Drop Across Frames Test Page</h2>
248246
const target = targetFrame.contentDocument.getElementById("target");
249247
target.innerText = "Dropped Successfully!";
250248

251-
status.innerText = "Dropped Successfully!";
252249
resetDrag();
253250
}
254251

0 commit comments

Comments
 (0)