Skip to content

[BUG] Staging API returns error for ROR ID URL pattern with proxy changes #369

@adambuttrick

Description

@adambuttrick

Describe the bug
Requests to the API for an organization using the URL ROR ID form (containing ror.org/) fail in the staging environment. The /v2/organizations/{orgid} API Gateway resource does not match paths that include an additional / inside the ID segment, and the /v2/{proxy+} catch-all that previously handled these requests was removed.

To Reproduce
Steps to reproduce the behavior:

  1. Send a GET request to https://api.staging.ror.org/v2/organizations/ror.org/000ehr937
  2. See that the request fails
  3. Compare with https://api.staging.ror.org/v2/organizations/000ehr937, which works fube

Expected behavior
The staging API should resolve /v2/organizations/ror.org/000ehr937 to the same record as /v2/organizations/000ehr937, matching production behavior.

Additional context
ror-community/new-deployment@a16efa2 removed the v2_proxy_staging and root_proxy_staging API Gateway resources/methods from ror/services/api/api_gateway_staging_full.tf. Adding something like an explicit nested resource for the ror.org/{rorid} path shape should fix.

Metadata

Metadata

Assignees

Labels

bugSomething is not working as defined

Type

No type
No fields configured for issues without a type.

Projects

Status

Complete

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions