Implement partner groups (#2131)

* PartnerGroup and PartnerGroupMembership models

- migrations
- factories
- validation specs

* Basic CRUD for PartnerGroups

TODO: add tests
TODO: need to be able to add partners

* Add partner to group via modal with dropdown

change partners display in group

Implement remove partner from partner group

* Implement tagging items with partner groups

* Implement PartnerRequestableItemsService

- if the partner is not in any groups, return all items in
organization
- if the partner is a member in some groups, returns items tagged
by those groups

* Update migrations to utilize different data structure

* Add associations and specs to verify them

* Update controller actions to fetch requestable items on partner frontend

* Be able to associate Partner to PartnerGroup

* Get the tabs to render properly based on URL

* WIP

* Got the functionality to work

* Add basic CRUD for partner group system specs

* Add partner association to group spec

* Remove unused code

* Fix broken specs

* Fix rubocop complaints

* Fix rubocop errors

* Fix broken spec

* Update

* Update items association on partners to indicate purpose

Co-authored-by: Edwin Mak <edwinthinks@gmail.com>

Author: albertchae

.rubocop.yml

@@ -11,6 +11,7 @@ AllCops:
   Exclude:
     - "vendor/**/*"
     - "db/schema.rb"
+    - "db/partners_schema.rb"
     - "db/seeds.rb"
     - "db/migrate/*"
     - "bin/*"
@@ -440,5 +441,8 @@ Rails/WhereExists:
   Enabled: false
 Rails/WhereNot:
   Enabled: false
+Rails/HasAndBelongsToMany:
+  Enabled: false
 Lint/EnsureReturn: # The service objects return self in an ensure block. Not using an explicit return does not do correct behavior
   Enabled: false
+

app/assets/javascripts/application.js

@@ -124,6 +124,10 @@ function load_quagga() {
 };
 $(document).on('turbolinks:load', load_quagga);
 
+/**
+ * Handle loading on specified tab in the URL parameter. In case we would like
+ * to direct a user to a specific tab on a page rather than the default.
+ */
 
 $(document).ready(function () {
   var hash = location.hash.replace(/^#/, '');  // ^ means starting, meaning only match the first hash

app/controllers/partner_groups_controller.rb

@@ -0,0 +1,46 @@
+class PartnerGroupsController < ApplicationController
+  def index
+    @partner_groups = current_organization.partner_groups
+
+    respond_to do |format|
+      format.html
+    end
+  end
+
+  def new
+    @partner_group = current_organization.partner_groups.new
+    @item_categories = current_organization.item_categories
+  end
+
+  def create
+    @partner_group = current_organization.partner_groups.new(partner_group_params)
+    if @partner_group.save
+      # Redirect to groups tab in Partner page.
+      redirect_to partners_path + "#nav-partner-groups", notice: "Partner group added!"
+    else
+      flash[:error] = "Something didn't work quite right -- try again?"
+      render action: :new
+    end
+  end
+
+  def edit
+    @partner_group = current_organization.partner_groups.find(params[:id])
+    @item_categories = current_organization.item_categories
+  end
+
+  def update
+    @partner_group = current_organization.partner_groups.find(params[:id])
+    if @partner_group.update(partner_group_params)
+      redirect_to partners_path + "#nav-partner-groups", notice: "Partner group edited!"
+    else
+      flash[:error] = "Something didn't work quite right -- try again?"
+      render action: :edit
+    end
+  end
+
+  private
+
+  def partner_group_params
+    params.require(:partner_group).permit(:name, item_category_ids: [])
+  end
+end

app/controllers/partners/children_controller.rb

@@ -35,6 +35,11 @@ def show
     def new
       family = current_partner.families.find_by!(id: params[:family_id])
       @child = family.children.new
+
+      requestable_items = PartnerFetchRequestableItemsService.new(partner_id: current_partner.partner.id).call
+      @formatted_requestable_items = requestable_items.map do |rt|
+        [rt.name, rt.id]
+      end
     end
 
     def active
@@ -45,6 +50,10 @@ def active
 
     def edit
       @child = current_partner.children.find_by(id: params[:id])
+      requestable_items = PartnerFetchRequestableItemsService.new(partner_id: current_partner.partner.id).call
+      @formatted_requestable_items = requestable_items.map do |rt|
+        [rt.name, rt.id]
+      end
     end
 
     def create
@@ -107,4 +116,4 @@ def fetch_valid_item_name(id)
       @valid_items.find { |vi| vi[:id] == id }&.fetch(:name)
     end
   end
-end
+end

app/controllers/partners/individuals_requests_controller.rb

@@ -2,9 +2,11 @@ module Partners
   class IndividualsRequestsController < BaseController
     def new
       @request = FamilyRequest.new({}, initial_items: 1)
-      @requestable_items = Organization.find(current_partner.diaper_bank_id).valid_items.map do |item|
-        [item[:name], item[:id]]
-      end.sort
+
+      requestable_items = PartnerFetchRequestableItemsService.new(partner_id: current_partner.partner.id).call
+      @formatted_requestable_items = requestable_items.map do |rt|
+        [rt.name, rt.id]
+      end
     end
 
     def create

app/controllers/partners/requests_controller.rb

@@ -11,10 +11,10 @@ def new
       @partner_request = Partners::Request.new
       @partner_request.item_requests.build
 
-      # Fetch the valid items
-      @requestable_items = Organization.find(current_partner.diaper_bank_id).valid_items.map do |item|
-        [item[:name], item[:id]]
-      end.sort
+      requestable_items = PartnerFetchRequestableItemsService.new(partner_id: current_partner.partner.id).call
+      @formatted_requestable_items = requestable_items.map do |rt|
+        [rt.name, rt.id]
+      end
     end
 
     def show
@@ -35,7 +35,7 @@ def create
       else
         @partner_request = create_service.partner_request
         @errors = create_service.errors
-        @requestable_items = Organization.find(current_partner.diaper_bank_id).valid_items.map do |item|
+        @formatted_requestable_items = Organization.find(current_partner.diaper_bank_id).valid_items.map do |item|
           [item[:name], item[:id]]
         end.sort
 

app/controllers/partners_controller.rb

@@ -6,7 +6,8 @@ class PartnersController < ApplicationController
 
   def index
     @unfiltered_partners_for_statuses = Partner.where(organization: current_organization)
-    @partners = Partner.where(organization: current_organization).class_filter(filter_params).alphabetized
+    @partners = Partner.includes(:partner_group).where(organization: current_organization).class_filter(filter_params).alphabetized
+    @partner_groups = PartnerGroup.includes(:partners, :item_categories).where(organization: current_organization)
 
     respond_to do |format|
       format.html
@@ -57,10 +58,12 @@ def show
 
   def new
     @partner = current_organization.partners.new
+    @partner_groups = current_organization.partner_groups
   end
 
   def edit
     @partner = current_organization.partners.find(params[:id])
+    @partner_groups = PartnerGroup.where(organization: current_organization)
   end
 
   def update
@@ -153,7 +156,7 @@ def reactivate
   private
 
   def partner_params
-    params.require(:partner).permit(:name, :email, :send_reminders, :quota, :notes, documents: [])
+    params.require(:partner).permit(:name, :email, :send_reminders, :quota, :notes, :partner_group_id, documents: [])
   end
 
   helper_method \

app/models/item_category.rb

@@ -4,7 +4,7 @@
 #
 #  id              :bigint           not null, primary key
 #  description     :text
-#  name            :string
+#  name            :string           not null
 #  created_at      :datetime         not null
 #  updated_at      :datetime         not null
 #  organization_id :integer          not null
@@ -16,4 +16,5 @@ class ItemCategory < ApplicationRecord
 
   belongs_to :organization
   has_many :items, -> { order(name: :asc) }, inverse_of: :item_category
+  has_many :partner_groups, dependent: :nullify
 end

app/models/organization.rb

@@ -45,6 +45,7 @@ class Organization < ApplicationRecord
     has_many :donations
     has_many :manufacturers
     has_many :partners
+    has_many :partner_groups
     has_many :purchases
     has_many :requests
     has_many :storage_locations

app/models/partner.rb

@@ -2,16 +2,17 @@
 #
 # Table name: partners
 #
-#  id              :integer          not null, primary key
-#  email           :string
-#  name            :string
-#  notes           :text
-#  quota           :integer
-#  send_reminders  :boolean          default(FALSE), not null
-#  status          :integer          default("uninvited")
-#  created_at      :datetime         not null
-#  updated_at      :datetime         not null
-#  organization_id :integer
+#  id               :integer          not null, primary key
+#  email            :string
+#  name             :string
+#  notes            :text
+#  quota            :integer
+#  send_reminders   :boolean          default(FALSE), not null
+#  status           :integer          default("uninvited")
+#  created_at       :datetime         not null
+#  updated_at       :datetime         not null
+#  organization_id  :integer
+#  partner_group_id :bigint
 #
 
 class Partner < ApplicationRecord
@@ -26,8 +27,11 @@ class Partner < ApplicationRecord
   enum status: { uninvited: 0, invited: 1, awaiting_review: 2, approved: 3, error: 4, recertification_required: 5, deactivated: 6 }
 
   belongs_to :organization
-  has_many :distributions, dependent: :destroy
+  belongs_to :partner_group, optional: true
+  has_many :item_categories, through: :partner_group
+  has_many :requestable_items, through: :item_categories, source: :items
 
+  has_many :distributions, dependent: :destroy
   has_many :requests, dependent: :destroy
 
   has_many_attached :documents