FreeIPA integration#147
Open
creideiki wants to merge 8 commits into
Open
Conversation
In saab-simc-admin#91 @albgus was working on a tool for adding FreeIPA hosts for Pallet Jack systems. However, he left the project before the tool vould be merged. Import his latest version as a base for future work.
RuboCop doesn't like including "then" in multi-line "if" statements. We still had a few of those floating around, but ignored. Fix them, and remove the configuration for ignoring them.
RuboCop prefers "!" instead of "not", but we don't. Disable that test.
Highlights: * Break up #process into several functions * Handle error returns better * Improved documentation * New dependency: hashie ~> 3
Contributor
Author
|
When setting up a FreeIPA server (either original or mirror), it is automatically added to the I have not dared try seeing what happens if you remove a server from that group. And anyway, it's a problem that can be solved with documentation. |
creideiki
added a commit
to creideiki/palletjack
that referenced
this pull request
Oct 18, 2017
…tion * 257ebd0 Document FreeIPA integration in the example warehouse * f0032a7 RuboCop configuration for pj2ipahost * a536d24 Major refactoring of pj2ipahost * 570322b Disable RuboCop warning Style/Not * 8a39a88 Fix remaining RuboCop warnings for Style/MultilineIfThen * 7504012 Add dependency on ipa-ruby * 6e7071b Import work in progress pj2ipahost tool from @albgus
creideiki
added a commit
to creideiki/palletjack
that referenced
this pull request
Oct 18, 2017
…tion * 257ebd0 Document FreeIPA integration in the example warehouse * f0032a7 RuboCop configuration for pj2ipahost * a536d24 Major refactoring of pj2ipahost * 570322b Disable RuboCop warning Style/Not * 8a39a88 Fix remaining RuboCop warnings for Style/MultilineIfThen * 7504012 Add dependency on ipa-ruby * 6e7071b Import work in progress pj2ipahost tool from @albgus
notCalle
previously requested changes
Oct 31, 2017
Contributor
Author
|
The RuboCop changes are related. They triggered warnings in |
notCalle
dismissed
their stale review
The intent was not clear, since 982c001 does not touch pj2ipa, and does not seem to change the outcome of any following commit. But we can keep it on hold here until I can actually test pj2ipa.
notCalle
approved these changes
Dec 23, 2020
|
more than me ;-)
/minus
…On Wed, Dec 23, 2020, 16:02 Calle Englund ***@***.***> wrote:
***@***.**** approved this pull request.
I wonder if I'm still allowed to approve things in here.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#147 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHAT7EAKT6YR2MLD4TNAZLSWIBBRANCNFSM4D63AFFA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing @albgus's abandoned work in #91, this is a reworked implementation of
palletjack2ipahostfor synchronising host objects and hostgroups from a warehouse to a FreeIPA server.This adds new functionality, and should therefore increase the minor version.
Changelog:
palletjack2ipahost, for syncing a warehouse to a FreeIPA server (FreeIPA integration #147)ipa-ruby ~> 0.0andhashie ~> 3(FreeIPA integration #147)role.yaml(FreeIPA integration #147)palletjack2ipahostcreates a boxipa.yamlin each system pallet to contain the one-time password for FreeIPA enrollment (FreeIPA integration #147)