Skip to content

Check for broken symbolic links on warehouse load#148

Open
creideiki wants to merge 1 commit into
saab-simc-admin:masterfrom
creideiki:broken-symlinks-133
Open

Check for broken symbolic links on warehouse load#148
creideiki wants to merge 1 commit into
saab-simc-admin:masterfrom
creideiki:broken-symlinks-133

Conversation

@creideiki
Copy link
Copy Markdown
Contributor

When encountering a symbolic link in the warehouse, check that the target exists before following it, and if not abort with an error naming both the source and the target.

Closes #133.

I don't think this merits a version bump or changelog entry in and of itself.

When encountering a symbolic link in the warehouse, check that the
target exists before following it, and if not abort with an error
naming both the source and the target.
@creideiki
Copy link
Copy Markdown
Contributor Author

If #149 gets merged, throwing a PalletJack::WarehouseError would probably be better than the current Errno::ENOENT.

creideiki added a commit to creideiki/palletjack that referenced this pull request Oct 18, 2017
…-133

* ae76a72 Check for broken symbolic links on warehouse load
creideiki added a commit to creideiki/palletjack that referenced this pull request Oct 18, 2017
…-133

* ae76a72 Check for broken symbolic links on warehouse load
@notCalle notCalle requested a review from me-minus January 26, 2018 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant