fix: vars

Author: jhefferman-sfdc

package.json

@@ -104,8 +104,8 @@
     "prepack": "sf-prepack",
     "prepare": "sf-install",
     "test": "wireit",
-    "test:nuts": "mocha \"**/*.nut.ts\" --slow 4500 --timeout 600000",
-    "test:nuts:local": "node -r dotenv/config ./node_modules/.bin/nyc mocha \"**/*.nut.ts\" --slow 4500 --timeout 600000",
+    "test:nuts": "mocha \"**/*.nut.ts\" --slow 4500 --timeout 600000 --parallel=false",
+    "test:nuts:local": "node -r dotenv/config ./node_modules/.bin/nyc mocha \"**/*.nut.ts\" --slow 4500 --timeout 600000 --parallel=false",
     "test:nut:local": "node -r dotenv/config ./node_modules/.bin/nyc mocha --slow 4500 --timeout 600000",
     "test:only": "wireit",
     "unlink-lwr": "yarn unlink @lwrjs/api @lwrjs/app-service @lwrjs/asset-registry @lwrjs/asset-transformer @lwrjs/auth-middleware @lwrjs/base-view-provider @lwrjs/base-view-transformer @lwrjs/client-modules @lwrjs/config @lwrjs/core @lwrjs/dev-proxy-server @lwrjs/diagnostics @lwrjs/esbuild @lwrjs/everywhere @lwrjs/fs-asset-provider @lwrjs/fs-watch @lwrjs/html-view-provider @lwrjs/instrumentation @lwrjs/label-module-provider @lwrjs/lambda @lwrjs/legacy-npm-module-provider @lwrjs/loader @lwrjs/lwc-module-provider @lwrjs/lwc-ssr @lwrjs/markdown-view-provider @lwrjs/module-bundler @lwrjs/module-registry @lwrjs/npm-module-provider @lwrjs/nunjucks-view-provider @lwrjs/o11y @lwrjs/resource-registry @lwrjs/router @lwrjs/security @lwrjs/server @lwrjs/shared-utils @lwrjs/static @lwrjs/tools @lwrjs/types @lwrjs/view-registry lwr",

test/commands/lightning/dev/component-preview/browserMenu.nut.ts

@@ -37,10 +37,6 @@ describe('lightning preview menu', () => {
     session = await getSession();
   });
 
-  after(async () => {
-    await session?.clean();
-  });
-
   beforeEach(async () => {
     childProcess = startLightningDevServer(
       session.project?.dir ?? '',
@@ -53,11 +49,11 @@ describe('lightning preview menu', () => {
   });
 
   afterEach(async () => {
+    if (page) await page.close();
+    if (browser) await browser.close();
     if (childProcess?.kill) {
       childProcess.kill('SIGKILL');
     }
-    if (page) await page.close();
-    if (browser) await browser.close();
   });
 
   it('should render select link and hamburger menu with helloWorld available and clickable', async () => {

test/commands/lightning/dev/component-preview/componentError.nut.ts

@@ -48,12 +48,11 @@ describe('lightning preview component error', () => {
   });
 
   after(async () => {
+    if (page) await page.close();
+    if (browser) await browser.close();
     if (childProcess?.kill) {
       childProcess.kill('SIGKILL');
     }
-    if (page) await page.close();
-    if (browser) await browser.close();
-    await session?.clean();
   });
 
   it('should render the error component and display the error modal', async () => {

test/commands/lightning/dev/component-preview/hmr.nut.ts

@@ -50,12 +50,11 @@ describe('lightning preview hot module reload', () => {
   });
 
   after(async () => {
+    if (page) await page.close();
+    if (browser) await browser.close();
     if (childProcess?.kill) {
       childProcess.kill('SIGKILL');
     }
-    if (page) await page.close();
-    if (browser) await browser.close();
-    await session?.clean();
   });
 
   it('should re-render component and hot reload .js changes', async () => {

test/commands/lightning/dev/component-preview/prompts.nut.ts

@@ -18,6 +18,7 @@ import type { Readable, Writable } from 'node:stream';
 import { TestSession } from '@salesforce/cli-plugins-testkit';
 import { Connection, Messages, Org } from '@salesforce/core';
 import { expect } from 'chai';
+import { type Browser, type Page } from 'playwright';
 import { MetaUtils } from '../../../../../src/shared/metaUtils.js';
 import { getSession } from '../helpers/sessionUtils.js';
 import {
@@ -38,6 +39,8 @@ describe('lightning preview component prompts', () => {
   let session: TestSession;
   let childProcess: ChildProcessByStdio<Writable, Readable, Readable> | undefined;
   let connection: Connection;
+  let browser: Browser;
+  let page: Page;
 
   before(async () => {
     session = await getSession();
@@ -51,16 +54,14 @@ describe('lightning preview component prompts', () => {
     await MetaUtils.setMyDomainFirstPartyCookieRequirement(connection, true);
   });
 
-  afterEach(() => {
+  afterEach(async () => {
+    if (page) await page.close();
+    if (browser) await browser.close();
     if (childProcess?.kill) {
       childProcess.kill('SIGKILL');
     }
   });
 
-  after(async () => {
-    await session?.clean();
-  });
-
   it('should error out when local dev is not enabled and AUTO_ENABLE_LOCAL_DEV is false', async () => {
     childProcess = startLightningDevServer(session.project?.dir, session.hubOrg.username, {
       AUTO_ENABLE_LOCAL_DEV: false,
@@ -95,14 +96,11 @@ describe('lightning preview component prompts', () => {
     childProcess.stdin?.write('\n');
 
     const previewUrl = await getPreviewURL(childProcess.stdout);
-    const { browser, page } = await getPreview(previewUrl, session.hubOrg.accessToken);
+    ({ browser, page } = await getPreview(previewUrl, session.hubOrg.accessToken));
 
-    // Assert that it rendered correctly
     const greetingLocator = page.getByText('Hello World');
+    await greetingLocator.waitFor({ state: 'visible' });
     expect(await greetingLocator.textContent()).to.equal('Hello World');
-
-    if (page) await page.close();
-    if (browser) await browser.close();
   });
 
   it('should render without a prompt and disable first party cookies when AUTO_ENABLE_LOCAL_DEV=true', async () => {
@@ -114,16 +112,13 @@ describe('lightning preview component prompts', () => {
     );
 
     const previewUrl = await getPreviewURL(childProcess.stdout);
-    const { browser, page } = await getPreview(previewUrl, session.hubOrg.accessToken);
+    ({ browser, page } = await getPreview(previewUrl, session.hubOrg.accessToken));
 
-    // Assert that it rendered correctly
     const greetingLocator = page.getByText('Hello World');
+    await greetingLocator.waitFor({ state: 'visible' });
     expect(await greetingLocator.textContent()).to.equal('Hello World');
 
     // Command with AUTO_ENABLE_LOCAL_DEV calls ensureFirstPartyCookiesNotRequired, so requirement is disabled
     expect(await MetaUtils.isFirstPartyCookieRequired(connection)).to.be.false;
-
-    if (page) await page.close();
-    if (browser) await browser.close();
   });
 });

test/commands/lightning/dev/helpers/sessionUtils.ts

@@ -19,6 +19,7 @@ import { PROJECT_PATH } from './utils.js';
 
 const SESSION_RETRIES = 3;
 const SESSION_RETRY_DELAY_MS = 5000;
+let cachedSession: TestSession;
 
 function isJwtAuthError(error: unknown): boolean {
   const message = error instanceof Error ? error.message : String(error);
@@ -32,19 +33,25 @@ function isJwtAuthError(error: unknown): boolean {
 }
 
 /**
- * Get the session. JWT auth is flaky hence the retries
+ * Get or create the shared session. Reuses one TestSession per process so we only stub process.cwd once
+ * (avoids "Attempted to wrap cwd which is already wrapped" when multiple NUT files run in one Mocha process).
+ * JWT auth is flaky hence the retries on create.
  *
- * @returns
+ * @returns The shared TestSession
  */
 export async function getSession(): Promise<TestSession> {
+  if (cachedSession) {
+    return cachedSession;
+  }
   let lastError: unknown;
   for (let attempt = 1; attempt <= SESSION_RETRIES; attempt++) {
     try {
       // eslint-disable-next-line no-await-in-loop
-      return await TestSession.create({
+      cachedSession = await TestSession.create({
         devhubAuthStrategy: 'AUTO',
         project: { sourceDir: PROJECT_PATH },
       });
+      return cachedSession;
     } catch (error) {
       lastError = error;
       if (!isJwtAuthError(error) || attempt === SESSION_RETRIES) {