From 8a9527364fcea3e540314d30e13267d427b2965f Mon Sep 17 00:00:00 2001 From: John Hefferman Date: Thu, 23 Jul 2026 09:46:05 -0600 Subject: [PATCH] chore: address post-merge NUT review comments (W-23400737) Follow-up to #676: - browserUtils: make getAccessToken non-exported (only used within the file) - sessionUtils: use global parseInt for consistency with the rest of the repo (src/configMeta.ts, src/shared/previewUtils.ts, devServerUtils.ts) Co-Authored-By: Claude Opus 4.8 --- test/commands/lightning/dev/helpers/browserUtils.ts | 2 +- test/commands/lightning/dev/helpers/sessionUtils.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/commands/lightning/dev/helpers/browserUtils.ts b/test/commands/lightning/dev/helpers/browserUtils.ts index 9cf84c36..bc299cd9 100644 --- a/test/commands/lightning/dev/helpers/browserUtils.ts +++ b/test/commands/lightning/dev/helpers/browserUtils.ts @@ -28,7 +28,7 @@ import { Org } from '@salesforce/core'; * @param session - TestSession with a default scratch org. * @returns The session ID string. */ -export async function getAccessToken(session: TestSession): Promise { +async function getAccessToken(session: TestSession): Promise { const scratchOrg = session.orgs.get('default'); const username = scratchOrg?.username ?? ''; if (!username) { diff --git a/test/commands/lightning/dev/helpers/sessionUtils.ts b/test/commands/lightning/dev/helpers/sessionUtils.ts index a0fb9452..1debd6b5 100644 --- a/test/commands/lightning/dev/helpers/sessionUtils.ts +++ b/test/commands/lightning/dev/helpers/sessionUtils.ts @@ -25,7 +25,7 @@ const PROJECT_PATH = path.resolve(PLUGIN_ROOT_PATH, 'test/projects/component-pre // Number of times TestSession will retry scratch org creation before failing. Scratch org // signup is intermittently flaky (RemoteOrgSignupFailed / C-9999); retrying avoids spurious // failures in the post-release pipeline. Overridable via TESTKIT_SETUP_RETRIES. -const SETUP_RETRIES = Number.parseInt(process.env.TESTKIT_SETUP_RETRIES ?? '', 10) || 3; +const SETUP_RETRIES = parseInt(process.env.TESTKIT_SETUP_RETRIES ?? '', 10) || 3; /** * Restores process.cwd() if it is currently a leaked sinon stub.