bulkCreate + options.returning on a table with hasTrigger enabled does not work

[iamjoyce]

What you are doing?

var Task = sequelize.define('task', {
    title: Sequelize.STRING,
    rating: { type: Sequelize.STRING, defaultValue: 3 }
}, {
    hasTrigger: true
});

Task.bulkCreate([{
    title: "Fix bug",
    rating: "5"
}, {
    title: "Write documentation",
    rating: "1"
}], {
    returning: true
});
// Error happens

What do you expect to happen?

Promise should return a list of successfully inserted instances with resulting values of autoIncrement attributes.

What is actually happening?

Unhandled rejection SequelizeDatabaseError: The target table '%TABLE_NAME_HERE%' of the DML statement cannot have any enabled triggers if the statement contains an OUTPUT clause without INTO clause.

Dialect: mssql
Database version: SQL Server 2014
Sequelize version: 3.24.3

[iamjoyce]

I've just realised a way to circumvent this issue.

Instead of {returning: true}, use {individualHooks: true}.

Caveat

1. The difference is in the number of SQL queries.

   For example, I have two records to bulkCreate. The correct bulkCreate will have one INSERT INTO statement, but this solution will have two INSERT INTO statements instead.**

2. If any of the INSERT INTO statements fails, there will be an error even if other record(s) was inserted successfully.

   To anyone who really needs help with this, wrap the bulkCreate statement with transaction:

   (Important: Performance is not guaranteed)

   sequelize.transaction().then(function (t) {// Use a promise-based transaction
       Task.bulkCreate([{
           title: "Fix bug",
           rating: "5"
         }, {
           title: "Write documentation",
           rating: "1"
         }], {
           individualHooks: true, // This returns autoincrement keys
           transaction: t // This ensures if one statement fails, all fail
       }).then(function (response) {
         t.commit(); // Manually commit if there are no errors
       }).catch(function (err) {
         t.rollback(); // Manually rollback if there is any error(s)
       });
   });

[rainabba]

IndividualHooks did help me work around this, but it did so by destroying the bulkCreate behavior and causing 1 insert for each record. I'm looking into query-generator.js. It looks like bulkInsertQuery() doesn't have the tmp table logic included in insertQuery (based on hasTrigger). Can anyone confirm this before I start on a PR? There already a branch addressing this?

[papb]

I will reopen this since it is still an issue.

Hi @rainabba! Thanks for being willing to help. If you can create a PR, that would be great!! Please look at PRs 7095 and 7096 before starting, perhaps you can use some of those ideas. Thanks! Let me know if you need further help.

[Judahh]

No prediction when this will be solved?